Skip to content

Commit 13007b2

Browse files
authored
Merge pull request kubernetes#2914 from gnufied/move-fsgroup-recursive-pod-policy-ga
KEP-695: Move configurableFSGroupPolicy to GA
2 parents 3d72dc6 + 9bd323c commit 13007b2

File tree

3 files changed

+15
-8
lines changed

3 files changed

+15
-8
lines changed
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
kep-number: 695
2+
beta:
3+
approver: "@deads2k"
4+
stable:
5+
approver: "@deads2k"

keps/sig-storage/695-skip-permission-change/README.md

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
- [x] (R) Design details are appropriately documented
3535
- [x] (R) Test plan is in place, giving consideration to SIG Architecture and SIG Testing input
3636
- [x] (R) Graduation criteria is in place
37-
- [ ] (R) Production readiness review completed
37+
- [x] (R) Production readiness review completed
3838
- [ ] Production readiness review approved
3939
- [x] "Implementation History" section is up-to-date for milestone
4040
- [x] User-facing documentation has been created in [kubernetes/website], for publication to [kubernetes.io]
@@ -171,9 +171,10 @@ type PodSecurityContext struct {
171171
- Metric name: storage_operation_errors_total{operation_name=volume_mount}
172172
- [Optional] Aggregation method: cumulative counter
173173
- Components exposing the metric: kubelet
174-
- volume ownerhip change timing mtrics: We are also going to add metrics that track time it takes for volume ownerhip change to happen. We will update this section with the name of metrics.
175-
176-
174+
- volume ownerhip change timing mtrics:
175+
- Metric name: storage_operation_duration_seconds{operation_name=volume_fsgroup_recursive_apply}
176+
- [Optional] Aggregation method: percentile
177+
- Components exposing the metric: kubelet
177178

178179
* **What are the reasonable SLOs (Service Level Objectives) for the above SLIs?**
179180
It is hard to give numbers that an admin could use to determine health of mount operation. In general we expect that after this feature is rolled out
@@ -253,7 +254,7 @@ details). For now we leave it here though.
253254
(non-production), with discussions in SIG-Storage regarding success of
254255
deployments. A metric will be added to report time taken to perform a
255256
volume ownership change. Also e2e tests that verify volume permissions with various `FSGroupChangePolicy`.
256-
* GA in 1.21, with Node E2E tests in place tagged with feature Storage
257+
* GA in 1.23, with Node E2E tests in place tagged with feature Storage
257258

258259

259260
[umbrella issues]: https://github.com/kubernetes/kubernetes/issues/69699
@@ -276,6 +277,7 @@ We will add a metric that measures the volume ownership change times.
276277
## Implementation History
277278

278279
- 2020-01-20 Initial KEP pull request submitted
280+
- 2020-11-05 Feature moved to beta
279281

280282
## Drawbacks [optional]
281283

keps/sig-storage/695-skip-permission-change/kep.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,12 @@ see-also:
2020
replaces:
2121
superseded-by:
2222

23-
latest-milestone: "v1.20"
24-
stage: "alpha"
23+
latest-milestone: "v1.23"
24+
stage: "stable"
2525
milestone:
2626
alpha: "v1.18"
2727
beta: "v1.20"
28-
stable: "v1.21"
28+
stable: "v1.23"
2929
feature-gates:
3030
- name: ConfigurableFSGroupPolicy
3131
components:

0 commit comments

Comments
 (0)