Skip to content

Commit 140a6e9

Browse files
committed
dynamic resource allocation: avoid nil vs. empty ambiguity in parameter references
Previously, empty string and nil both meant the same thing (core API group). We don't need two different ways of expressing that.
1 parent e69ccae commit 140a6e9

File tree

1 file changed

+4
-4
lines changed
  • keps/sig-node/3063-dynamic-resource-allocation

1 file changed

+4
-4
lines changed

keps/sig-node/3063-dynamic-resource-allocation/README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1529,10 +1529,10 @@ type ResourceClaimTemplate struct {
15291529
// parameters for a ResourceClass.
15301530
type ResourceClassParametersReference struct {
15311531
// APIGroup is the group for the resource being referenced.
1532-
// If APIGroup is not specified, the specified Kind must be in the core API group.
1532+
// If APIGroup is empty, the specified Kind must be in the core API group.
15331533
// For any other third-party types, APIGroup is required.
15341534
// +optional
1535-
APIGroup *string
1535+
APIGroup string
15361536
// Kind is the type of resource being referenced
15371537
Kind string
15381538
// Name is the name of resource being referenced
@@ -1548,10 +1548,10 @@ type ResourceClassParametersReference struct {
15481548
// as the ResourceClaim.
15491549
type ResourceClaimParametersReference struct {
15501550
// APIGroup is the group for the resource being referenced.
1551-
// If APIGroup is not specified, the specified Kind must be in the core API group.
1551+
// If APIGroup is empty, the specified Kind must be in the core API group.
15521552
// For any other third-party types, APIGroup is required.
15531553
// +optional
1554-
APIGroup *string
1554+
APIGroup string
15551555
// Kind is the type of resource being referenced
15561556
Kind string
15571557
// Name is the name of resource being referenced

0 commit comments

Comments
 (0)