Skip to content

Commit 171f02c

Browse files
authored
Make some cleanup in KEP PRR template and building scripts (kubernetes#2636)
* Make some cleanup in kep prr template and building scripts * Add comment about PRR approver list Signed-off-by: Ricardo Pchevuzinske Katz <[email protected]> * Add again windows and darwin into platforms Signed-off-by: Ricardo Pchevuzinske Katz <[email protected]>
1 parent 0639baf commit 171f02c

File tree

3 files changed

+14
-10
lines changed

3 files changed

+14
-10
lines changed

hack/verify-build.sh

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -20,14 +20,7 @@ set -o pipefail
2020

2121
PLATFORMS=(
2222
linux/amd64
23-
linux/386
24-
linux/arm
25-
linux/arm64
26-
linux/ppc64le
27-
linux/s390x
2823
windows/amd64
29-
windows/386
30-
freebsd/amd64
3124
darwin/amd64
3225
)
3326

keps/NNNN-kep-template/kep.yaml

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,14 @@ reviewers:
1414
approvers:
1515
- TBD
1616
- "@oscar.doe"
17-
prr-approvers:
18-
- TBD
19-
- "@bob.doe"
17+
18+
##### WARNING !!! ######
19+
# prr-approvers has been moved to its own location
20+
# You should create your own in keps/prod-readiness
21+
# Please make a copy of keps/prod-readiness/template/nnnn.yaml
22+
# to keps/prod-readiness/sig-xxxxx/00000.yaml (replace with kep number)
23+
#prr-approvers:
24+
2025
see-also:
2126
- "/keps/sig-aaa/1234-we-heard-you-like-keps"
2227
- "/keps/sig-bbb/2345-everyone-gets-a-kep"
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
# The KEP must have an approver from the
2+
# "prod-readiness-approvers" group
3+
# of http://git.k8s.io/enhancements/OWNERS_ALIASES
4+
kep-number: 0000
5+
alpha:
6+
approver: ""

0 commit comments

Comments
 (0)