@@ -512,7 +512,10 @@ rollout. Similarly, consider large clusters and how enablement/disablement
512
512
will rollout across nodes.
513
513
-->
514
514
515
- N/A.
515
+ Due to the feature gate on the external-provisioner, rolling out this feature
516
+ does not affect existing Pods that use PVCs. It also does not affect
517
+ VolumeSnapshots that are created prior to rolling out the feature, ie, the
518
+ volume mode of an existing VolumeSnapshot can be modified while creating a PVC.
516
519
517
520
###### What specific metrics should inform a rollback?
518
521
@@ -555,7 +558,8 @@ checking if there are objects with field X set) may be a last resort. Avoid
555
558
logs or events for this purpose.
556
559
-->
557
560
558
- N/A.
561
+ If the feature gate is enabled in the external-provisioner and snapshot-controller,
562
+ this feature will always be in use when creating a PVC from a VolumeSnapshot.
559
563
560
564
###### How can someone using this feature know that it is working for their instance?
561
565
@@ -570,7 +574,7 @@ Recall that end users cannot usually observe component logs or access metrics.
570
574
571
575
- [x] Events
572
576
- Event Reason: ProvisioningFailed
573
- - Event Message: ailed to provision volume with StorageClass "csi-hostpath-sc": error getting handle for DataSource Type
577
+ - Event Message: Failed to provision volume with StorageClass "csi-hostpath-sc": error getting handle for DataSource Type
574
578
VolumeSnapshot by Name new-snapshot-demo: requested volume default/hpvc-restore modifies the mode of the source volume
575
579
but does not have permission to do so. snapshot.storage.kubernetes.io/allow-volume-mode-change annotation is not present
576
580
on snapshotcontent snapcontent-8d709f2e-db04-444f-aae2-e17d6c5398dd
642
646
643
647
###### Will enabling / using this feature result in any new API calls?
644
648
645
- This feature does not add any new API calls.
649
+ This feature adds an event write to the API server when PVC creation is blocked.
646
650
647
651
###### Will enabling / using this feature result in introducing new API types?
648
652
@@ -682,7 +686,9 @@ details). For now, we leave it here.
682
686
683
687
###### How does this feature react if the API server and/or etcd is unavailable?
684
688
685
- No new API calls are introduced as part of this feature.
689
+ In case PVC creation is blocked due to this feature, the failure event will not be emitted
690
+ due to the unavailability of the API server. Users will need to refer to the external-provisioner
691
+ logs to determine why PVC creation is failing.
686
692
687
693
###### What are other known failure modes?
688
694
@@ -701,6 +707,9 @@ For each of them, fill in the following information by copying the below templat
701
707
702
708
###### What steps should be taken if SLOs are not being met to determine the problem?
703
709
710
+ The user needs to read the logs of the external-provisioner to determine the reason
711
+ behind why PVC creation is failing.
712
+
704
713
## Implementation History
705
714
706
715
<!--
0 commit comments