Skip to content

Commit 1ad1e7f

Browse files
committed
Addess comments in PRR
1 parent 4eec5e0 commit 1ad1e7f

File tree

1 file changed

+14
-5
lines changed
  • keps/sig-storage/3141-prevent-volume-mode-conversion

1 file changed

+14
-5
lines changed

keps/sig-storage/3141-prevent-volume-mode-conversion/README.md

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -512,7 +512,10 @@ rollout. Similarly, consider large clusters and how enablement/disablement
512512
will rollout across nodes.
513513
-->
514514
515-
N/A.
515+
Due to the feature gate on the external-provisioner, rolling out this feature
516+
does not affect existing Pods that use PVCs. It also does not affect
517+
VolumeSnapshots that are created prior to rolling out the feature, ie, the
518+
volume mode of an existing VolumeSnapshot can be modified while creating a PVC.
516519
517520
###### What specific metrics should inform a rollback?
518521
@@ -555,7 +558,8 @@ checking if there are objects with field X set) may be a last resort. Avoid
555558
logs or events for this purpose.
556559
-->
557560
558-
N/A.
561+
If the feature gate is enabled in the external-provisioner and snapshot-controller,
562+
this feature will always be in use when creating a PVC from a VolumeSnapshot.
559563
560564
###### How can someone using this feature know that it is working for their instance?
561565
@@ -570,7 +574,7 @@ Recall that end users cannot usually observe component logs or access metrics.
570574
571575
- [x] Events
572576
- Event Reason: ProvisioningFailed
573-
- Event Message: ailed to provision volume with StorageClass "csi-hostpath-sc": error getting handle for DataSource Type
577+
- Event Message: Failed to provision volume with StorageClass "csi-hostpath-sc": error getting handle for DataSource Type
574578
VolumeSnapshot by Name new-snapshot-demo: requested volume default/hpvc-restore modifies the mode of the source volume
575579
but does not have permission to do so. snapshot.storage.kubernetes.io/allow-volume-mode-change annotation is not present
576580
on snapshotcontent snapcontent-8d709f2e-db04-444f-aae2-e17d6c5398dd
@@ -642,7 +646,7 @@ No.
642646
643647
###### Will enabling / using this feature result in any new API calls?
644648
645-
This feature does not add any new API calls.
649+
This feature adds an event write to the API server when PVC creation is blocked.
646650
647651
###### Will enabling / using this feature result in introducing new API types?
648652
@@ -682,7 +686,9 @@ details). For now, we leave it here.
682686
683687
###### How does this feature react if the API server and/or etcd is unavailable?
684688
685-
No new API calls are introduced as part of this feature.
689+
In case PVC creation is blocked due to this feature, the failure event will not be emitted
690+
due to the unavailability of the API server. Users will need to refer to the external-provisioner
691+
logs to determine why PVC creation is failing.
686692
687693
###### What are other known failure modes?
688694
@@ -701,6 +707,9 @@ For each of them, fill in the following information by copying the below templat
701707
702708
###### What steps should be taken if SLOs are not being met to determine the problem?
703709
710+
The user needs to read the logs of the external-provisioner to determine the reason
711+
behind why PVC creation is failing.
712+
704713
## Implementation History
705714
706715
<!--

0 commit comments

Comments
 (0)