Skip to content

Commit 1f423cf

Browse files
committed
node: topologymgr: address PRR review comments
Signed-off-by: Swati Sehgal <[email protected]>
1 parent 938276b commit 1f423cf

File tree

1 file changed

+9
-4
lines changed

1 file changed

+9
-4
lines changed

keps/sig-node/693-topology-manager/README.md

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -743,7 +743,7 @@ Memory Manager and Device Manager to either admit a pod to the node or reject it
743743

744744
###### Can the feature be disabled once it has been enabled (i.e. can we roll back the enablement)?
745745

746-
Yes, this feature can be disabledby specifying `TopologyManager` feature gate
746+
Yes, this feature can be disabled by specifying `TopologyManager` feature gate
747747
in the kubelet configuration. Note that disabling the feature gate requires
748748
kubelet restart for the changes to take effect. In case no pods consuming
749749
resources aligned by Topology Manager are running on the node, disabling
@@ -800,8 +800,10 @@ Monitor the following metrics:
800800

801801
###### How can an operator determine if the feature is in use by workloads?
802802

803-
Inspect the kubelet configuration of the nodes: check feature gates and the policies
804-
or policies configured.
803+
The operator can look at `topology_manager_admission_requests_total` and `topology_manager_admission_errors_total`
804+
metrics to determine if topology manager is performing its admission check.
805+
In addition to that, kubelet configuration of the nodes can be inspected to check feature gates and the policies
806+
configured.
805807

806808
###### How can someone using this feature know that it is working for their instance?
807809

@@ -834,7 +836,10 @@ No.
834836

835837
### Scalability
836838

837-
No, this is a node-local feature.
839+
Topology Manager is a component within kubelet for alignment of resources
840+
based on resource distribution across NUMA nodes and configured policy.
841+
Since this is a node-local feature, there are no calls to the API
842+
server or to the cloud provider and hence does not impact scalability.
838843

839844
###### Will enabling / using this feature result in any new API calls?
840845

0 commit comments

Comments
 (0)