Skip to content

Commit 1fb84d2

Browse files
committed
Answer more questions in the KEP
1 parent cad2c20 commit 1fb84d2

File tree

1 file changed

+19
-16
lines changed
  • keps/sig-cli/3638-built-in-command-shadowing

1 file changed

+19
-16
lines changed

keps/sig-cli/3638-built-in-command-shadowing/README.md

Lines changed: 19 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -378,7 +378,8 @@ feature.
378378
379379
NOTE: Also set `disable-supported` to `true` or `false` in `kep.yaml`.
380380
-->
381-
Yes, we can roll back to a previous release of `kubectl`
381+
Yes, we can roll back to a previous release of `kubectl` or it can be simply done by user
382+
by unsetting environment variable.
382383

383384
###### What happens if we reenable the feature if it was previously rolled back?
384385
Shadowing will continue being supported without any impact on default behavior.
@@ -416,13 +417,15 @@ feature flags will be enabled on some API servers and not others during the
416417
rollout. Similarly, consider large clusters and how enablement/disablement
417418
will rollout across nodes.
418419
-->
420+
No
419421

420422
###### What specific metrics should inform a rollback?
421423

422424
<!--
423425
What signals should users be paying attention to when the feature is young
424426
that might indicate a serious problem?
425427
-->
428+
N/A
426429

427430
###### Were upgrade and rollback tested? Was the upgrade->downgrade->upgrade path tested?
428431

@@ -431,12 +434,14 @@ Describe manual testing that was done and the outcomes.
431434
Longer term, we may want to require automated upgrade/rollback tests, but we
432435
are missing a bunch of machinery and tooling and can't do that now.
433436
-->
437+
N/A
434438

435439
###### Is the rollout accompanied by any deprecations and/or removals of features, APIs, fields of API types, flags, etc.?
436440

437441
<!--
438442
Even if applying deprecation policies, they may still surprise some users.
439443
-->
444+
N/A
440445

441446
### Monitoring Requirements
442447

@@ -454,6 +459,7 @@ Ideally, this should be a metric. Operations against the Kubernetes API (e.g.,
454459
checking if there are objects with field X set) may be a last resort. Avoid
455460
logs or events for this purpose.
456461
-->
462+
N/A
457463

458464
###### How can someone using this feature know that it is working for their instance?
459465

@@ -465,14 +471,7 @@ Please describe all items visible to end users below with sufficient detail so t
465471
and operation of this feature.
466472
Recall that end users cannot usually observe component logs or access metrics.
467473
-->
468-
469-
- [ ] Events
470-
- Event Reason:
471-
- [ ] API .status
472-
- Condition name:
473-
- Other field:
474-
- [ ] Other (treat as last resort)
475-
- Details:
474+
N/A
476475

477476
###### What are the reasonable SLOs (Service Level Objectives) for the enhancement?
478477

@@ -490,26 +489,22 @@ high level (needs more precise definitions) those may be things like:
490489
These goals will help you determine what you need to measure (SLIs) in the next
491490
question.
492491
-->
492+
N/A
493493

494494
###### What are the SLIs (Service Level Indicators) an operator can use to determine the health of the service?
495495

496496
<!--
497497
Pick one more of these and delete the rest.
498498
-->
499-
500-
- [ ] Metrics
501-
- Metric name:
502-
- [Optional] Aggregation method:
503-
- Components exposing the metric:
504-
- [ ] Other (treat as last resort)
505-
- Details:
499+
N/A
506500

507501
###### Are there any missing metrics that would be useful to have to improve observability of this feature?
508502

509503
<!--
510504
Describe the metrics themselves and the reasons why they weren't added (e.g., cost,
511505
implementation difficulties, etc.).
512506
-->
507+
N/A
513508

514509
### Dependencies
515510

@@ -533,6 +528,7 @@ and creating new ones, as well as about cluster-level services (e.g. DNS):
533528
- Impact of its outage on the feature:
534529
- Impact of its degraded performance or high-error rates on the feature:
535530
-->
531+
No
536532

537533
### Scalability
538534

@@ -545,6 +541,7 @@ For beta, this section is required: reviewers must answer these questions.
545541
For GA, this section is required: approvers should be able to confirm the
546542
previous answers based on experience in the field.
547543
-->
544+
N/A
548545

549546
###### Will enabling / using this feature result in any new API calls?
550547

@@ -560,6 +557,7 @@ Focusing mostly on:
560557
- periodic API calls to reconcile state (e.g. periodic fetching state,
561558
heartbeats, leader election, etc.)
562559
-->
560+
No
563561

564562
###### Will enabling / using this feature result in introducing new API types?
565563

@@ -569,6 +567,7 @@ Describe them, providing:
569567
- Supported number of objects per cluster
570568
- Supported number of objects per namespace (for namespace-scoped objects)
571569
-->
570+
No
572571

573572
###### Will enabling / using this feature result in any new calls to the cloud provider?
574573

@@ -577,6 +576,7 @@ Describe them, providing:
577576
- Which API(s):
578577
- Estimated increase:
579578
-->
579+
No
580580

581581
###### Will enabling / using this feature result in increasing size or count of the existing API objects?
582582

@@ -586,6 +586,7 @@ Describe them, providing:
586586
- Estimated increase in size: (e.g., new annotation of size 32B)
587587
- Estimated amount of new objects: (e.g., new Object X for every existing Pod)
588588
-->
589+
No
589590

590591
###### Will enabling / using this feature result in increasing time taken by any operations covered by existing SLIs/SLOs?
591592

@@ -597,6 +598,7 @@ Think about adding additional work or introducing new steps in between
597598
598599
[existing SLIs/SLOs]: https://git.k8s.io/community/sig-scalability/slos/slos.md#kubernetes-slisslos
599600
-->
601+
No
600602

601603
###### Will enabling / using this feature result in non-negligible increase of resource usage (CPU, RAM, disk, IO, ...) in any components?
602604

@@ -609,6 +611,7 @@ This through this both in small and large cases, again with respect to the
609611
610612
[supported limits]: https://git.k8s.io/community//sig-scalability/configs-and-limits/thresholds.md
611613
-->
614+
No
612615

613616
### Troubleshooting
614617

0 commit comments

Comments
 (0)