@@ -90,6 +90,10 @@ tags, and then generate with `hack/update-toc.sh`.
90
90
- [ Risks and Mitigations] ( #risks-and-mitigations )
91
91
- [ Design Details] ( #design-details )
92
92
- [ Test Plan] ( #test-plan )
93
+ - [ Prerequisite testing updates] ( #prerequisite-testing-updates )
94
+ - [ Unit tests] ( #unit-tests )
95
+ - [ Integration tests] ( #integration-tests )
96
+ - [ e2e tests] ( #e2e-tests )
93
97
- [ Graduation Criteria] ( #graduation-criteria )
94
98
- [ Upgrade / Downgrade Strategy] ( #upgrade--downgrade-strategy )
95
99
- [ Version Skew Strategy] ( #version-skew-strategy )
@@ -254,14 +258,7 @@ proposal will be implemented, this is the place to discuss them.
254
258
255
259
<!--
256
260
**Note:** *Not required until targeted at a release.*
257
-
258
- Consider the following in developing a test plan for this enhancement:
259
- - Will there be e2e and integration tests, in addition to unit tests?
260
- - How will it be tested in isolation vs with other components?
261
-
262
- No need to outline all of the test cases, just the general strategy. Anything
263
- that would count as tricky in the implementation, and anything particularly
264
- challenging to test, should be called out.
261
+ The goal is to ensure that we don't accept enhancements with inadequate testing.
265
262
266
263
All code is expected to have adequate tests (eventually with coverage
267
264
expectations). Please adhere to the [Kubernetes testing guidelines][testing-guidelines]
@@ -270,6 +267,66 @@ when drafting this test plan.
270
267
[testing-guidelines]: https://git.k8s.io/community/contributors/devel/sig-testing/testing.md
271
268
-->
272
269
270
+ [ ] I/we understand the owners of the involved components may require updates to
271
+ existing tests to make this code solid enough prior to committing the changes necessary
272
+ to implement this enhancement.
273
+
274
+ ##### Prerequisite testing updates
275
+
276
+ <!--
277
+ Based on reviewers feedback describe what additional tests need to be added prior
278
+ implementing this enhancement to ensure the enhancements have also solid foundations.
279
+ -->
280
+
281
+ ##### Unit tests
282
+
283
+ <!--
284
+ In principle every added code should have complete unit test coverage, so providing
285
+ the exact set of tests will not bring additional value.
286
+ However, if complete unit test coverage is not possible, explain the reason of it
287
+ together with explanation why this is acceptable.
288
+ -->
289
+
290
+ <!--
291
+ Additionally, for Alpha try to enumerate the core package you will be touching
292
+ to implement this enhancement and provide the current unit coverage for those
293
+ in the form of:
294
+ - <package>: <date> - <current test coverage>
295
+ The data can be easily read from:
296
+ https://testgrid.k8s.io/sig-testing-canaries#ci-kubernetes-coverage-unit
297
+
298
+ This can inform certain test coverage improvements that we want to do before
299
+ extending the production code to implement this enhancement.
300
+ -->
301
+
302
+ - ` <package> ` : ` <date> ` - ` <test coverage> `
303
+
304
+ ##### Integration tests
305
+
306
+ <!--
307
+ This question should be filled when targeting a release.
308
+ For Alpha, describe what tests will be added to ensure proper quality of the enhancement.
309
+
310
+ For Beta and GA, add links to added tests together with links to k8s-triage for those tests:
311
+ https://storage.googleapis.com/k8s-triage/index.html
312
+ -->
313
+
314
+ - <test >: <link to test coverage >
315
+
316
+ ##### e2e tests
317
+
318
+ <!--
319
+ This question should be filled when targeting a release.
320
+ For Alpha, describe what tests will be added to ensure proper quality of the enhancement.
321
+
322
+ For Beta and GA, add links to added tests together with links to k8s-triage for those tests:
323
+ https://storage.googleapis.com/k8s-triage/index.html
324
+
325
+ We expect no non-infra related flakes in the last month as a GA graduation criteria.
326
+ -->
327
+
328
+ - <test >: <link to test coverage >
329
+
273
330
### Graduation Criteria
274
331
275
332
<!--
0 commit comments