You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: keps/sig-storage/1790-recover-resize-failure/README.md
+2-2Lines changed: 2 additions & 2 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -75,7 +75,7 @@ shrink on underlying volume, but it can fool the quota system in believing
75
75
the user is using less storage than he/she actually is.
76
76
77
77
To solve this problem - we propose that although users are allowed to reduce size of their
78
-
PVC (as long as requested size >=`pvc.Status.Capacity`), quota calculation
78
+
PVC (as long as requested size > `pvc.Status.Capacity`), quota calculation
79
79
will use `max(pvc.Spec.Capacity, pvc.Status.AllocatedResources)` and reduction in `pvc.Status.AllocatedResources`
80
80
is only done by resize-controller after verifying volume size using `ControllerGetVolume` csi RPC call.
81
81
@@ -92,7 +92,7 @@ is only done by resize-controller after verifying volume size using `ControllerG
92
92
93
93
As part of this proposal, we are mainly proposing three changes:
94
94
95
-
1. Relax API validation on PVC update so as reducing `pvc.Spec.Resoures` is allowed, as long as requested size is `>=pvc.Status.Capacity`.
95
+
1. Relax API validation on PVC update so as reducing `pvc.Spec.Resoures` is allowed, as long as requested size is `>pvc.Status.Capacity`.
96
96
2. Add a new field in PVC API called - `pvc.Status.AllocatedResources` for the purpose of tracking used storage size. By default only api-server or resize-controller can set this field.
97
97
3. Update quota code to use `max(pvc.Spec.Resources, pvc.Status.AllocatedResources)` when evaluating usage for PVC.
0 commit comments