|
43 | 43 | Items marked with (R) are required *prior to targeting to a milestone / release*.
|
44 | 44 |
|
45 | 45 | - [x] (R) Enhancement issue in release milestone, which links to KEP dir in [kubernetes/enhancements] (not the initial KEP PR)
|
46 |
| -- [ ] (R) KEP approvers have approved the KEP status as `implementable` |
| 46 | +- [x] (R) KEP approvers have approved the KEP status as `implementable` |
47 | 47 | - [x] (R) Design details are appropriately documented
|
48 | 48 | - [ ] (R) Test plan is in place, giving consideration to SIG Architecture and SIG Testing input (including test refactors)
|
49 | 49 | - [ ] e2e Tests for all Beta API Operations (endpoints)
|
50 | 50 | - [ ] (R) Ensure GA e2e tests meet requirements for [Conformance Tests](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/conformance-tests.md)
|
51 | 51 | - [ ] (R) Minimum Two Week Window for GA e2e tests to prove flake free
|
52 | 52 | - [ ] (R) Graduation criteria is in place
|
53 | 53 | - [ ] (R) [all GA Endpoints](https://github.com/kubernetes/community/pull/1806) must be hit by [Conformance Tests](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/conformance-tests.md)
|
54 |
| -- [ ] (R) Production readiness review completed |
55 |
| -- [ ] (R) Production readiness review approved |
| 54 | +- [x] (R) Production readiness review completed |
| 55 | +- [x] (R) Production readiness review approved |
56 | 56 | - [ ] "Implementation History" section is up-to-date for milestone
|
57 | 57 | - [ ] User-facing documentation has been created in [kubernetes/website], for publication to [kubernetes.io]
|
58 | 58 | - [ ] Supporting documentation—e.g., additional design documents, links to mailing list discussions/SIG meetings, relevant PRs/issues, release notes
|
@@ -284,9 +284,9 @@ It will silently drop the sleep prestop hook if someone wants to add that to the
|
284 | 284 | Both kubelet and kube-apiserver will need enable the feature gate for the full featureset
|
285 | 285 | to be present. If both components disable the feature gate, this feature will be cleanly unavailable.
|
286 | 286 |
|
287 |
| -If only the kube-apiserver enable this feature, kubelet won't understand the new field and may either ignore it or raise an error. |
| 287 | +If only the kube-apiserver enable this feature, validation will pass, but kubelet won't understand the new field and will ignore it when pod is terminating. |
288 | 288 |
|
289 |
| -If only the kubelet enable this feature, when creating/updating a resource with the sleepAction, the API server will reject the request with an error indicating that the field is unknown or unsupported. |
| 289 | +If only the kubelet enable this feature, when creating/updating a resource with the sleepAction, this field will be silently dropped. |
290 | 290 |
|
291 | 291 | ## Production Readiness Review Questionnaire
|
292 | 292 |
|
|
382 | 382 |
|
383 | 383 | ###### Will enabling / using this feature result in any new API calls?
|
384 | 384 |
|
385 |
| -LifecycleHandler objects have one new fields per version they define, increasing their size slightly. |
386 |
| -See `Implementation` part |
| 385 | +No |
387 | 386 |
|
388 | 387 | ###### Will enabling / using this feature result in introducing new API types?
|
389 | 388 |
|
|
395 | 394 |
|
396 | 395 | ###### Will enabling / using this feature result in increasing size or count of the existing API objects?
|
397 | 396 |
|
398 |
| -No |
| 397 | +LifecycleHandler objects have one new fields per version they define, increasing their size slightly. |
| 398 | +See `Implementation` part |
399 | 399 |
|
400 | 400 | ###### Will enabling / using this feature result in increasing time taken by any operations covered by existing SLIs/SLOs?
|
401 | 401 |
|
|
0 commit comments