Skip to content

Commit 29e8351

Browse files
committed
bring to implementable
1 parent 6ce7493 commit 29e8351

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

keps/sig-node/3960-pod-lifecycle-sleep-action/README.md

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -43,16 +43,16 @@
4343
Items marked with (R) are required *prior to targeting to a milestone / release*.
4444

4545
- [x] (R) Enhancement issue in release milestone, which links to KEP dir in [kubernetes/enhancements] (not the initial KEP PR)
46-
- [ ] (R) KEP approvers have approved the KEP status as `implementable`
46+
- [x] (R) KEP approvers have approved the KEP status as `implementable`
4747
- [x] (R) Design details are appropriately documented
4848
- [ ] (R) Test plan is in place, giving consideration to SIG Architecture and SIG Testing input (including test refactors)
4949
- [ ] e2e Tests for all Beta API Operations (endpoints)
5050
- [ ] (R) Ensure GA e2e tests meet requirements for [Conformance Tests](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/conformance-tests.md)
5151
- [ ] (R) Minimum Two Week Window for GA e2e tests to prove flake free
5252
- [ ] (R) Graduation criteria is in place
5353
- [ ] (R) [all GA Endpoints](https://github.com/kubernetes/community/pull/1806) must be hit by [Conformance Tests](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/conformance-tests.md)
54-
- [ ] (R) Production readiness review completed
55-
- [ ] (R) Production readiness review approved
54+
- [x] (R) Production readiness review completed
55+
- [x] (R) Production readiness review approved
5656
- [ ] "Implementation History" section is up-to-date for milestone
5757
- [ ] User-facing documentation has been created in [kubernetes/website], for publication to [kubernetes.io]
5858
- [ ] Supporting documentation—e.g., additional design documents, links to mailing list discussions/SIG meetings, relevant PRs/issues, release notes
@@ -284,9 +284,9 @@ It will silently drop the sleep prestop hook if someone wants to add that to the
284284
Both kubelet and kube-apiserver will need enable the feature gate for the full featureset
285285
to be present. If both components disable the feature gate, this feature will be cleanly unavailable.
286286

287-
If only the kube-apiserver enable this feature, kubelet won't understand the new field and may either ignore it or raise an error.
287+
If only the kube-apiserver enable this feature, validation will pass, but kubelet won't understand the new field and will ignore it when pod is terminating.
288288

289-
If only the kubelet enable this feature, when creating/updating a resource with the sleepAction, the API server will reject the request with an error indicating that the field is unknown or unsupported.
289+
If only the kubelet enable this feature, when creating/updating a resource with the sleepAction, this field will be silently dropped.
290290

291291
## Production Readiness Review Questionnaire
292292

@@ -382,8 +382,7 @@ No
382382

383383
###### Will enabling / using this feature result in any new API calls?
384384

385-
LifecycleHandler objects have one new fields per version they define, increasing their size slightly.
386-
See `Implementation` part
385+
No
387386

388387
###### Will enabling / using this feature result in introducing new API types?
389388

@@ -395,7 +394,8 @@ No
395394

396395
###### Will enabling / using this feature result in increasing size or count of the existing API objects?
397396

398-
No
397+
LifecycleHandler objects have one new fields per version they define, increasing their size slightly.
398+
See `Implementation` part
399399

400400
###### Will enabling / using this feature result in increasing time taken by any operations covered by existing SLIs/SLOs?
401401

keps/sig-node/3960-pod-lifecycle-sleep-action/kep.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ authors:
44
- "@AxeZhan"
55
owning-sig: sig-node
66
participating-sigs: []
7-
status: provisional
7+
status: implementable
88
creation-date: 2023-04-22
99
reviewers:
1010
- "@thockin"

0 commit comments

Comments
 (0)