Skip to content

Commit 29fc453

Browse files
committed
go back to provisional for now, and update with sig-arch decision in the to crd or not to crd section
1 parent 9aca52f commit 29fc453

File tree

2 files changed

+9
-10
lines changed

2 files changed

+9
-10
lines changed

keps/sig-multicluster/2149-clusterid/README.md

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -486,23 +486,22 @@ spec:
486486

487487
_That is the question._
488488

489-
`[UNRESOLVED] Must resolve before alpha`
489+
While this document has thus far referred to the `ClusterClaim` resource as being implemented as a CRD, another implementation point of debate has been whether this belongs in the core Kubernetes API, particularly the `id.k8s.io ClusterClaim`. A dependable cluster ID or cluster name has previously been discussed in other forums (such as [this SIG-Architecture thread](https://groups.google.com/g/kubernetes-sig-architecture/c/mVGobfD4TpY/m/nkdbkX1iBwAJ) from 2018, or, as mentioned above, the [Cluster API subproject](https://github.com/kubernetes-sigs/cluster-api/issues/4044) which implemented [their own solution](https://github.com/kubernetes-sigs/cluster-api/pull/4048).) It is the opinion of SIG-Multicluster that the function of the proposed `ClusterClaim` CRD is of broad utility and becomes more useful the more ubiquitous it is, not only in multicluster set ups.
490490

491-
> While this document has thus far referred to the `ClusterClaim` resource as being implemented as a CRD, another implementation point of debate has been whether this belongs in the core Kubernetes API, particularly the `id.k8s.io ClusterClaim`. A dependable cluster ID or cluster name has previously been discussed in other forums (such as [this SIG-Architecture thread](https://groups.google.com/g/kubernetes-sig-architecture/c/mVGobfD4TpY/m/nkdbkX1iBwAJ) from 2018, or, as mentioned above, the [Cluster API subproject](https://github.com/kubernetes-sigs/cluster-api/issues/4044) which implemented [their own solution](https://github.com/kubernetes-sigs/cluster-api/pull/4048).) It is the opinion of SIG-Multicluster that the function of the proposed `ClusterClaim` CRD is of broad utility and becomes more useful the more ubiquitous it is, not only in multicluster set ups.
491+
This has led to the discussion of whether or not we should pursue adding this resource type not as a CRD associated with SIG-Multicluster, but as a core Kubernetes API implemented in `kubernetes/kubernetes`. A short pro/con list is enclosed at the end of this section.
492492

493-
> This has led to the discussion of whether or not we should pursue adding this resource type not as a CRD associated with SIG-Multicluster, but as a core Kubernetes API implemented in `kubernetes/kubernetes`. A short pro/con list is enclosed at the end of this section.
494-
495-
> One effect of that decision is related to the upgrade path. Implementing this resource only in k/k will restrict the types of clusters that can use cluster ID to only ones on the target version (or above) of Kubernetes, unless a separate backporting CRD is made available to them. At that point, with two install options, other issues arise. How do backported clusters deal with migrating their CRD data to the core k/k objects during upgrade -- will the code around the formal k/k implementation be sensitive to the backport CRD and migrate itself? Will users have to handle upgrades in a bespoke manner?
493+
One effect of that decision is related to the upgrade path. Implementing this resource only in k/k will restrict the types of clusters that can use cluster ID to only ones on the target version (or above) of Kubernetes, unless a separate backporting CRD is made available to them. At that point, with two install options, other issues arise. How do backported clusters deal with migrating their CRD data to the core k/k objects during upgrade -- will the code around the formal k/k implementation be sensitive to the backport CRD and migrate itself? Will users have to handle upgrades in a bespoke manner?
496494

497495
| | CRD | k/k |
498496
|-----------------------|----------------------------------------------------------------------------------|---------------------------------------------------|
499-
| Built-in / ubiquitous | Unlikely (?) | Likely (?) |
497+
| Ubiquitous | No | Yes |
498+
| Default always set | No | Yes |
500499
| Deployment | Must be installed by the cluster lifecycle management, or as a manual setup step | In every cluster over target milestone |
501-
| Schema validation | Can use OpenAPI v3 validation | Can use the built-in Kubernetes schema validation |
502-
| Blockers | Making a sigs-repo | Official API review |
500+
| Schema validation | OpenAPI v3 validation | Can use the built-in Kubernetes schema validation |
501+
| Blockers | Official API review if using *.k8s.io | Official API review |
503502
| Conformance testing | Not possible now, and no easy path forward | Standard |
504503

505-
`[/UNRESOLVED]`
504+
**In the end, SIG-Multicluster discussed this with SIG-Architecture and it was decided to stick with the plan to use a CRD.** Notes from this conversation are in the [SIG-Architecture meeting agenda](https://docs.google.com/document/d/1BlmHq5uPyBUDlppYqAAzslVbAO8hilgjqZUTaNXUhKM/preview) for 3/25/2021.
506505

507506

508507
### Test Plan

keps/sig-multicluster/2149-clusterid/kep.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ owning-sig: sig-multicluster
77
#participating-sigs:
88
# - sig-aaa
99
# - sig-bbb
10-
status: implementable
10+
status: provisional
1111
creation-date: 2020-11-13
1212
reviewers:
1313
- "@mikedanese"

0 commit comments

Comments
 (0)