You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: keps/sig-node/2535-ensure-secret-pulled-images/README.md
+6-2Lines changed: 6 additions & 2 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -143,7 +143,6 @@ used is not present, thus enforcing authentication / re-authentication.
143
143
User with multiple tenants will be able to support all image pull policies without
144
144
concern that one tenant will gain access to an image that they don't have rights to.
145
145
146
-
147
146
#### Story 2
148
147
User will will no longer have to inject the Pull Always Image Pull Policy to
149
148
ensure all tenants have rights to the images that are already present on a host.
@@ -170,7 +169,10 @@ container runtime cache. To mitigate, images can be garbage collected at boot.
170
169
171
170
## Design Details
172
171
173
-
See PR
172
+
Kubelet will track, in memory, a hash map for the credentials that were successfully used to pull an image. The hash map
173
+
will not be persisted to disk, in alpha. For alpha explicitly, we will not reuse or add other state manager concepts to kubelet.
174
+
175
+
See PR for detailed design / behavior documentation.
174
176
175
177
### Test Plan
176
178
@@ -341,6 +343,8 @@ Why should this KEP _not_ be implemented. N/A
341
343
- Make the behavior change enabled by default by changing the feature gate to true by default instead of false by default.
342
344
- Discussions went back and forth on whether this should go directly to GA as a fix or alpha as a feature gate. It seems this should be the default security posture for pullIfNotPresent as it is not clear to admins/users that an image pulled by a first pod with authentication can be used by a second pod without authentication. The performance cost should be minimal as only the manifest needs to be re-authenticated. But after further review and discussion with MrunalP we'll go ahead and have a kubelet feature gate with default off for alpha in v1.22.
343
345
- Set the flag at some other scope e.g. pod spec (doing it at the pod spec was rejected by SIG-Node).
346
+
- For beta/ga we may revisit/replace the in memory hash map in kubelet design, with an extention to the CRI API for having the container runtime
0 commit comments