Skip to content

Commit 2bca996

Browse files
committed
fix some PRR feedback
1 parent 4d0a1df commit 2bca996

File tree

1 file changed

+13
-4
lines changed
  • keps/sig-apps/2804-consolidate-workload-controllers-status

1 file changed

+13
-4
lines changed

keps/sig-apps/2804-consolidate-workload-controllers-status/README.md

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -207,6 +207,8 @@ and make progress.
207207
- Modifying the existing states of deployment controller
208208
- Changing the definition of States
209209
- Introduce new api for existing conditions
210+
- To properly implement Progressing condition, `.spec.progressDeadlineSeconds` field has to be introduced in
211+
DaemonSet and StatefulSet to describe the time when the controllers should declare the workload as `failed`.
210212

211213
## Proposal
212214

@@ -315,6 +317,9 @@ proposal will be implemented, this is the place to discuss them.
315317
Unit and E2E tests will be added to cover the
316318
API validation, behavioral change of DaemonSet and StatefulSet with feature gate enabled and disabled.
317319

320+
- Validating all possible states of old and new conditions. Checking that the changes in underlying Pod statuses correspond to the conditions.
321+
- Testing `progressDeadlineSeconds` and feature gates.
322+
318323
<!--
319324
**Note:** *Not required until targeted at a release.*
320325
@@ -449,6 +454,8 @@ enhancement:
449454
CRI or CNI may require updating that component before the kubelet.
450455
-->
451456

457+
TBD
458+
452459
## Production Readiness Review Questionnaire
453460

454461
<!--
@@ -492,7 +499,9 @@ Pick one of these and delete the rest.
492499
- kube-apiserver
493500

494501
###### Does enabling the feature change any default behavior?
495-
The default behavior won't change but the new conditions will be additive.
502+
No. The default behavior won't change.
503+
The default values for newly introduced `progressDeadlineSeconds` fields might change when graduating it after getting feedback from users.
504+
Only new conditions will be added with no effect on existing conditions.
496505

497506
<!--
498507
Any change of default behavior may be surprising to users or break existing
@@ -511,7 +520,7 @@ NOTE: Also set `disable-supported` to `true` or `false` in `kep.yaml`.
511520

512521
###### What happens if we reenable the feature if it was previously rolled back?
513522

514-
The DaemonSet, StatefulSet controller sstarts respecting the `progressDeadlineSeconds` again
523+
The DaemonSet, StatefulSet controller starts respecting the `progressDeadlineSeconds` again.
515524

516525
###### Are there any tests for feature enablement/disablement?
517526

@@ -670,8 +679,8 @@ previous answers based on experience in the field.
670679

671680
###### Will enabling / using this feature result in any new API calls?
672681
Yes
673-
- Update StatefulSet, DaemonSet status
674-
- StatefulSet, DaemonSet controllers make these calls
682+
- Update of DaemonSet, StatefulSet status
683+
- Controllers could make additional update calls when syncing the resources
675684
<!--
676685
Describe them, providing:
677686
- API call type (e.g. PATCH pods)

0 commit comments

Comments
 (0)