@@ -207,6 +207,8 @@ and make progress.
207
207
- Modifying the existing states of deployment controller
208
208
- Changing the definition of States
209
209
- Introduce new api for existing conditions
210
+ - To properly implement Progressing condition, ` .spec.progressDeadlineSeconds ` field has to be introduced in
211
+ DaemonSet and StatefulSet to describe the time when the controllers should declare the workload as ` failed ` .
210
212
211
213
## Proposal
212
214
@@ -315,6 +317,9 @@ proposal will be implemented, this is the place to discuss them.
315
317
Unit and E2E tests will be added to cover the
316
318
API validation, behavioral change of DaemonSet and StatefulSet with feature gate enabled and disabled.
317
319
320
+ - Validating all possible states of old and new conditions. Checking that the changes in underlying Pod statuses correspond to the conditions.
321
+ - Testing ` progressDeadlineSeconds ` and feature gates.
322
+
318
323
<!--
319
324
**Note:** *Not required until targeted at a release.*
320
325
@@ -449,6 +454,8 @@ enhancement:
449
454
CRI or CNI may require updating that component before the kubelet.
450
455
-->
451
456
457
+ TBD
458
+
452
459
## Production Readiness Review Questionnaire
453
460
454
461
<!--
@@ -492,7 +499,9 @@ Pick one of these and delete the rest.
492
499
- kube-apiserver
493
500
494
501
###### Does enabling the feature change any default behavior?
495
- The default behavior won't change but the new conditions will be additive.
502
+ No. The default behavior won't change.
503
+ The default values for newly introduced ` progressDeadlineSeconds ` fields might change when graduating it after getting feedback from users.
504
+ Only new conditions will be added with no effect on existing conditions.
496
505
497
506
<!--
498
507
Any change of default behavior may be surprising to users or break existing
@@ -511,7 +520,7 @@ NOTE: Also set `disable-supported` to `true` or `false` in `kep.yaml`.
511
520
512
521
###### What happens if we reenable the feature if it was previously rolled back?
513
522
514
- The DaemonSet, StatefulSet controller sstarts respecting the ` progressDeadlineSeconds ` again
523
+ The DaemonSet, StatefulSet controller starts respecting the ` progressDeadlineSeconds ` again.
515
524
516
525
###### Are there any tests for feature enablement/disablement?
517
526
@@ -670,8 +679,8 @@ previous answers based on experience in the field.
670
679
671
680
###### Will enabling / using this feature result in any new API calls?
672
681
Yes
673
- - Update StatefulSet, DaemonSet status
674
- - StatefulSet, DaemonSet controllers make these calls
682
+ - Update of DaemonSet, StatefulSet status
683
+ - Controllers could make additional update calls when syncing the resources
675
684
<!--
676
685
Describe them, providing:
677
686
- API call type (e.g. PATCH pods)
0 commit comments