Skip to content

Commit 31cf998

Browse files
authored
Merge pull request kubernetes#1508 from skilxn-go/framework
Scheduler Framework: Rename `PostFilter` to `PreScore`
2 parents 94bba42 + 05c611d commit 31cf998

File tree

3 files changed

+8
-10
lines changed

3 files changed

+8
-10
lines changed
Binary file not shown.

keps/sig-scheduling/20180409-scheduling-framework.md

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ superseded-by:
3333
- [Queue sort](#queue-sort)
3434
- [Pre-filter](#pre-filter)
3535
- [Filter](#filter)
36-
- [Post-filter](#post-filter)
36+
- [Pre-Score](#pre-score)
3737
- [Scoring](#scoring)
3838
- [Reserve](#reserve)
3939
- [Permit](#permit)
@@ -165,7 +165,7 @@ are called.
165165
One plugin may register at multiple extension points to perform more complex or
166166
stateful tasks.
167167

168-
![image](20180409-scheduling-framework-extensions.png)
168+
![image](20200125-scheduling-framework-extensions.png)
169169

170170
### Queue sort
171171

@@ -195,14 +195,12 @@ filter plugin marks the node as infeasible, the remaining plugins will not be
195195
called for that node. Nodes may be evaluated concurrently, and Filter may be called
196196
more than once in the same scheduling cycle.
197197

198-
### Post-filter
198+
### Pre-Score
199199

200-
This is an informational extension point. Plugins will be called with a list of
201-
nodes that passed the filtering phase. A plugin may use this data to update
202-
internal state or to generate logs/metrics.
200+
**Notice: `Pre-Score` is available since v1alpha2, and it's known as `Post-Filter` before this version.**
203201

204-
**Note:** Plugins wishing to perform "pre-scoring" work should use the
205-
post-filter extension point.
202+
This is an informational extension point for performing pre-scoring work. Plugins will be called with a list of
203+
nodes that passed the filtering phase. A plugin may use this data to update internal state or to generate logs/metrics.
206204

207205
### Scoring
208206

@@ -479,7 +477,7 @@ type Plugins struct {
479477
QueueSort []Plugin
480478
PreFilter []Plugin
481479
Filter []Plugin
482-
PostFilter []Plugin
480+
PreScore []Plugin
483481
Score []Plugin
484482
Reserve []Plugin
485483
Permit []Plugin
@@ -705,4 +703,4 @@ End-to-end tests are not needed when integration tests can provided adequate cov
705703
# IMPLEMENTATION HISTORY
706704

707705
TODO: write down milestones and target releases, and a plan for how we will
708-
gracefully move to the new system
706+
gracefully move to the new system
127 KB
Loading

0 commit comments

Comments
 (0)