Skip to content

Commit 32dc3a2

Browse files
authored
KEP-1885: Update Azure File csi migration (kubernetes#3360)
* KEP-1885: Update Azure File csi migration test plan revert kep.yaml fix fix comments * set as stable * use beta version * Update 1885.yaml * Update README.md * Update kep.yaml * Update kep.yaml
1 parent bd2a6d5 commit 32dc3a2

File tree

3 files changed

+45
-3
lines changed

3 files changed

+45
-3
lines changed
Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
11
kep-number: 1885
22
beta:
3-
approver: "@wojtek-t"
3+
approver: "@wojtek-t"
4+
stable:
5+
approver: "@wojtek-t"

keps/sig-storage/1885-csi-migration-azurefile/README.md

Lines changed: 39 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,12 @@
66
- [Summary](#summary)
77
- [New Feature Gates](#new-feature-gates)
88
- [Production Readiness Review Questionnaire](#production-readiness-review-questionnaire)
9+
- [Design Details](#design-details)
10+
- [Test Plan](#test-plan)
11+
- [Prerequisite testing updates](#prerequisite-testing-updates)
12+
- [Unit tests](#unit-tests)
13+
- [Integration tests](#integration-tests)
14+
- [e2e tests](#e2e-tests)
915
- [Implementation History](#implementation-history)
1016
<!-- /toc -->
1117

@@ -40,6 +46,36 @@ used as as described in its parent KEP. For all other contents, please refer to
4046

4147
Please refer to the [CSI Migration Production Readiness Review Questionnaire](https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/625-csi-migration#production-readiness-review-questionnaire).
4248

49+
## Design Details
50+
### Test Plan
51+
52+
[X] I/we understand the owners of the involved components may require updates to
53+
existing tests to make this code solid enough prior to committing the changes necessary
54+
to implement this enhancement.
55+
56+
##### Prerequisite testing updates
57+
58+
No additional tests are needed, rather the issue is orchestrating CSI driver
59+
deployment for prow jobs. This has been complicated by the cloud provider
60+
extraction work, which no longer permits cloud provider specific orchestration
61+
in the k/k repository. This means that it is not possible to run any test for
62+
AzureFile in k/k. All such tests have been moved to the [Azure File CSI Driver repo](https://github.com/kubernetes-sigs/azurefile-csi-driver).
63+
64+
##### Unit tests
65+
66+
https://github.com/kubernetes/csi-translation-lib/blob/master/plugins/azure_file_test.go
67+
68+
##### Integration tests
69+
70+
N/A
71+
72+
##### e2e tests
73+
74+
Support for tests after AzureFile migration have been [added to
75+
azurefile-csi-driver](https://github.com/kubernetes-sigs/azurefile-csi-driver/tree/master/test/e2e).
76+
77+
The e2e tests are now covered in [azurefile-csi-driver-e2e-migration](https://testgrid.k8s.io/provider-azure-azurefile-csi-driver#pr-azurefile-csi-driver-e2e-migration).
78+
4379
## Implementation History
4480

4581
Major milestones in the life cycle of a KEP should be tracked in `Implementation History`.
@@ -56,3 +92,6 @@ Major milestones for Azure File in-tree plugin CSI migration:
5692

5793
- 1.24
5894
- AzureFile CSI migration to Beta, on by default
95+
96+
- 1.26
97+
- AzureFile CSI migration to GA, on by default

keps/sig-storage/1885-csi-migration-azurefile/kep.yaml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,17 +20,18 @@ see-also:
2020
replaces:
2121

2222
# The target maturity stage in the current dev cycle for this KEP.
23-
stage: beta
23+
stage: stable
2424

2525
# The most recent milestone for which work toward delivery of this KEP has been
2626
# done. This can be the current (upcoming) milestone, if it is being actively
2727
# worked on.
28-
latest-milestone: "v1.24"
28+
latest-milestone: "v1.26"
2929

3030
# The milestone at which this feature was, or is targeted to be, at each stage.
3131
milestone:
3232
alpha: "v1.15"
3333
beta: "v1.21"
34+
stable: "v1.26"
3435

3536
# The following PRR answers are required at alpha release
3637
# List the feature gate name and the components for which it must be enabled

0 commit comments

Comments
 (0)