Skip to content

Commit 3490c6e

Browse files
committed
KEP-2485: Remove kube-controller-manager from feature gate users
This feature gate is not required by the kube-controller-manager for this feature
1 parent e8e0772 commit 3490c6e

File tree

2 files changed

+6
-9
lines changed

2 files changed

+6
-9
lines changed

keps/sig-storage/2485-read-write-once-pod-pv-access-mode/README.md

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -376,9 +376,9 @@ proposal will be implemented, this is the place to discuss them.
376376

377377
In Kubernetes, we should add a new ReadWriteOncePod persistent volume access
378378
mode to PersistentVolumes and PersistentVolumeClaims. This change will require
379-
adding a feature gate to the kube-apiserver, kube-controller-manager,
380-
kube-scheduler, and kubelet. Validation logic will need updating to accept this
381-
access mode type if the feature gate is enabled.
379+
adding a feature gate to the kube-apiserver, kube-scheduler, and kubelet.
380+
Validation logic will need updating to accept this access mode type if the
381+
feature gate is enabled.
382382

383383
```golang
384384
// can be mounted read/write mode to exactly 1 pod
@@ -627,10 +627,9 @@ enhancement:
627627
-->
628628

629629
In order to upgrade a cluster to use this feature, the user will need to restart
630-
the kube-apiserver, kube-controller-manager, kube-scheduler, and kubelet with
631-
the ReadWriteOncePod feature gate enabled. Additionally they will need to
632-
update their CSI drivers and sidecars to versions that depend on the new
633-
Kubernetes API and CSI spec.
630+
the kube-apiserver, kube-scheduler, and kubelet with the ReadWriteOncePod
631+
feature gate enabled. Additionally they will need to update their CSI drivers
632+
and sidecars to versions that depend on the new Kubernetes API and CSI spec.
634633

635634
When downgrading a cluster to disable this feature, the user will need to
636635
restart the kube-apiserver with the ReadWriteOncePod feature gate disabled. When
@@ -755,7 +754,6 @@ Pick one of these and delete the rest.
755754
- Feature gate name: ReadWriteOncePod
756755
- Components depending on the feature gate:
757756
- kube-apiserver
758-
- kube-controller-manager
759757
- kube-scheduler
760758
- kubelet
761759

keps/sig-storage/2485-read-write-once-pod-pv-access-mode/kep.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@ feature-gates:
4141
- name: ReadWriteOncePod
4242
components:
4343
- kube-apiserver
44-
- kube-controller-manager
4544
- kube-scheduler
4645
- kubelet
4746
disable-supported: true

0 commit comments

Comments
 (0)