Skip to content

Commit 37e7f93

Browse files
committed
add manual test for removal
1 parent 18026bc commit 37e7f93

File tree

1 file changed

+4
-3
lines changed
  • keps/sig-node/2129-remove-cadvisor-json-metrics

1 file changed

+4
-3
lines changed

keps/sig-node/2129-remove-cadvisor-json-metrics/README.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,11 +29,11 @@
2929
## Release Signoff Checklist
3030

3131
- [X] (R) Enhancement issue in release milestone, which links to KEP dir in [kubernetes/enhancements](https://github.com/kubernetes/enhancements/issues/1867)
32-
- [ ] (R) KEP approvers have approved the KEP status as `implementable`
32+
- [X] (R) KEP approvers have approved the KEP status as `implementable`
3333
- [X] (R) Design details are appropriately documented
34-
- [ ] (R) Test plan is in place, giving consideration to SIG Architecture and SIG Testing input
34+
- [X] (R) Test plan is in place, giving consideration to SIG Architecture and SIG Testing input
3535
- [X] (R) Graduation criteria is in place
36-
- [ ] (R) Production readiness review completed
36+
- [X] (R) Production readiness review completed
3737
- [ ] Production readiness review approved
3838
- [ ] "Implementation History" section is up-to-date for milestone
3939
- [ ] User-facing documentation has been created in [kubernetes/website], for publication to [kubernetes.io]
@@ -102,6 +102,7 @@ Remove the `--enable-cadvisor-json-endpoints` flag and the kubelet stops serving
102102

103103
* This will not have any e2e testing.
104104
* There are no existing kubernetes e2e tests which check these endpoints.
105+
* When removing the endpoints, we will manually test that the endpoints are no longer being served.
105106

106107
### Graduation Criteria
107108

0 commit comments

Comments
 (0)