Skip to content

Commit 3b80df9

Browse files
Update on Oct 26
1 parent 23fa960 commit 3b80df9

File tree

1 file changed

+15
-14
lines changed
  • keps/sig-storage/3751-volume-attributes-class

1 file changed

+15
-14
lines changed

keps/sig-storage/3751-volume-attributes-class/README.md

Lines changed: 15 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -176,24 +176,26 @@ type PersistentVolumeClaimSpec struct {
176176
// Condition is used to document the last error controller sees
177177
const (
178178
...
179-
// PersistentVolumeClaimVolumeAttriburesModifyError - a user trigger modify volume of pvc has error
180-
PersistentVolumeClaimVolumeAttriburesModifyError PersistentVolumeClaimConditionType = "VolumeAttriburesModifyError"
179+
// Applying the target VolumeAttributesClass encountered an error
180+
PersistentVolumeClaimVolumeModifyVolumeError PersistentVolumeClaimConditionType = "ModifyVolumeError"
181+
// Volume is being modified
182+
PersistentVolumeClaimVolumeModifyingVolume PersistentVolumeClaimConditionType = "ModifyingVolume"
181183
...
182184
)
183185
184186
185187
// PersistentVolumeClaimStatus represents the status of PV claim
186188
type PersistentVolumeClaimStatus struct {
187189
...
190+
// CurrentVolumeAttributesClassName is the current name of the VolumeAttributesClass the PVC is using
191+
CurrentVolumeAttributesClassName *string
188192
// ModifyVolumeStatus represents the status object of ControllerModifyVolume operation
189-
ModifyVolumeStatus ModifyVolumeStatus
193+
ModifyVolumeStatus *ModifyVolumeStatus
190194
...
191195
}
192196
193197
// ModifyVolumeStatus represents the status object of ControllerModifyVolume operation
194198
type ModifyVolumeStatus struct {
195-
// CurrentVolumeAttributesClassName is the current name of the VolumeAttributesClass the PVC is using
196-
CurrentVolumeAttributesClassName string
197199
// TargetVolumeAttributesClassName is the name of the VolumeAttributesClass the PVC currently being reconciled
198200
TargetVolumeAttributesClassName string
199201
// Status is the status of the ControllerModifyVolume operation
@@ -205,15 +207,14 @@ type ModifyVolumeStatus struct {
205207
type PersistentVolumeClaimModifyVolumeStatus string
206208
207209
const (
208-
// Pending indicates that the PersistentVolumeClaim cannot be modified due to requirements not being met, such as
209-
// the specified VolumeAttributesClass doesn't exist
210-
PersistentVolumeClaimControllerModifyVolumePending PersistentVolumeClaimModifyVolumeStatus = "ControllerModifyVolumePending"
211-
// State set when modify volume controller starts modifying the volume
212-
PersistentVolumeClaimControllerModifyVolumeInProgress PersistentVolumeClaimModifyVolumeStatus = "ControllerModifyVolumeInProgress"
213-
// State set when modify volume has failed in modify volume controller with a terminal error.
214-
// When the request has been rejected as invalid by the CSI driver. To resolve this error,
215-
// the PersistentVolumeClaim needs to specify a valid VolumeAttributesClass.
216-
PersistentVolumeClaimControllerModifyVolumeInfeasible PersistentVolumeClaimModifyVolumeStatus = "ControllerModifyVolumeInfeasible"
210+
// Pending indicates that the PersistentVolumeClaim cannot be modified due to unmet requirements, such as
211+
// the specified VolumeAttributesClass not existing
212+
PersistentVolumeClaimModifyVolumePending PersistentVolumeClaimModifyVolumeStatus = "Pending"
213+
// InProgress indicates that the volume is being modified
214+
PersistentVolumeClaimModifyVolumeInProgress PersistentVolumeClaimModifyVolumeStatus = "InProgress"
215+
// Infeasible indicates that the request has been rejected as invalid by the CSI driver. To
216+
// resolve the error, a valid VolumeAttributesClass needs to be specified
217+
PersistentVolumeClaimModifyVolumeInfeasible PersistentVolumeClaimModifyVolumeStatus = "Infeasible"
217218
)
218219
219220
```

0 commit comments

Comments
 (0)