You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: keps/sig-node/2403-pod-resources-allocatable-resources/README.md
+9-6Lines changed: 9 additions & 6 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -257,7 +257,7 @@ No
257
257
258
258
###### Can the feature be disabled once it has been enabled (i.e. can we roll back the enablement)?
259
259
260
-
Yes, through feature gates.
260
+
Yes, through feature gate. Once GA, the feature can't be disabled and is always enabled.
261
261
262
262
###### What happens if we reenable the feature if it was previously rolled back?
263
263
@@ -304,7 +304,9 @@ No (Not applicable)
304
304
305
305
###### What are the reasonable SLOs (Service Level Objectives) for the enhancement?
306
306
307
-
Not Applicable
307
+
100% in normal operation. The proposed API exposes in read only mode kubelet internal data, critical for functioning of the kubelet.
308
+
This data has to be available 100% of the time for the proper functioning of the kubelet, thus is expected to be available 100% of time.
309
+
The only possible error source is the API calls being throttled by the rate-limiting introduced with the GA graduation of the parent KEP 606.
308
310
309
311
###### What are the SLIs (Service Level Indicators) an operator can use to determine the health of the service?
310
312
@@ -316,9 +318,9 @@ Not Applicable
316
318
317
319
###### Are there any missing metrics that would be useful to have to improve observability of this feature?
318
320
319
-
As part of this feature enhancement, per-API-endpoint resources metrics are being added; to observe this feature the `pod_resources_endpoint_requests_get_allocatable` metric should be used. We will also add error counting metrics to improve the observability of the API.
320
-
321
-
TBD
321
+
As part of this feature enhancement, per-API-endpoint resources metrics are being added; to observe this feature the `pod_resources_endpoint_requests_get_allocatable` metric should be used.
322
+
We added the `pod_resources_endpoint_errors_get_allocatable` metric to report errors. Because the nature of the API (exposing data already used by the kubelet with minimal processing)
323
+
the error counter is expected to be stable zero.
322
324
323
325
### Dependencies
324
326
@@ -371,7 +373,8 @@ Consumers of the API should treat unexpected errors as bugs of this API.
371
373
372
374
###### What steps should be taken if SLOs are not being met to determine the problem?
373
375
374
-
Not available.
376
+
Check the error code to learn if the consumer of the API is being throttle by rate limiting introduced in the parent KEP 606.
377
+
Check the kubelet logs to learn about resource allocation errors.
0 commit comments