Skip to content

Commit 42c90b7

Browse files
committed
KEP-2043: address PRR and reviewer comments
Add clarifications and rephrasing in the text. Signed-off-by: Francesco Romani <[email protected]>
1 parent e2fe92e commit 42c90b7

File tree

1 file changed

+9
-6
lines changed
  • keps/sig-node/2403-pod-resources-allocatable-resources

1 file changed

+9
-6
lines changed

keps/sig-node/2403-pod-resources-allocatable-resources/README.md

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -257,7 +257,7 @@ No
257257

258258
###### Can the feature be disabled once it has been enabled (i.e. can we roll back the enablement)?
259259

260-
Yes, through feature gates.
260+
Yes, through feature gate. Once GA, the feature can't be disabled and is always enabled.
261261

262262
###### What happens if we reenable the feature if it was previously rolled back?
263263

@@ -304,7 +304,9 @@ No (Not applicable)
304304

305305
###### What are the reasonable SLOs (Service Level Objectives) for the enhancement?
306306

307-
Not Applicable
307+
100% in normal operation. The proposed API exposes in read only mode kubelet internal data, critical for functioning of the kubelet.
308+
This data has to be available 100% of the time for the proper functioning of the kubelet, thus is expected to be available 100% of time.
309+
The only possible error source is the API calls being throttled by the rate-limiting introduced with the GA graduation of the parent KEP 606.
308310

309311
###### What are the SLIs (Service Level Indicators) an operator can use to determine the health of the service?
310312

@@ -316,9 +318,9 @@ Not Applicable
316318

317319
###### Are there any missing metrics that would be useful to have to improve observability of this feature?
318320

319-
As part of this feature enhancement, per-API-endpoint resources metrics are being added; to observe this feature the `pod_resources_endpoint_requests_get_allocatable` metric should be used. We will also add error counting metrics to improve the observability of the API.
320-
321-
TBD
321+
As part of this feature enhancement, per-API-endpoint resources metrics are being added; to observe this feature the `pod_resources_endpoint_requests_get_allocatable` metric should be used.
322+
We added the `pod_resources_endpoint_errors_get_allocatable` metric to report errors. Because the nature of the API (exposing data already used by the kubelet with minimal processing)
323+
the error counter is expected to be stable zero.
322324

323325
### Dependencies
324326

@@ -371,7 +373,8 @@ Consumers of the API should treat unexpected errors as bugs of this API.
371373

372374
###### What steps should be taken if SLOs are not being met to determine the problem?
373375

374-
Not available.
376+
Check the error code to learn if the consumer of the API is being throttle by rate limiting introduced in the parent KEP 606.
377+
Check the kubelet logs to learn about resource allocation errors.
375378

376379
## Implementation History
377380

0 commit comments

Comments
 (0)