Skip to content

Commit 44dac05

Browse files
authored
Merge pull request kubernetes#2649 from bridgetkromhout/dual-stack-stable
KEP-563 - dual-stack updates
2 parents d3ac22c + 8a21028 commit 44dac05

File tree

2 files changed

+31
-12
lines changed

2 files changed

+31
-12
lines changed

keps/sig-network/563-dual-stack/README.md

Lines changed: 27 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1232,14 +1232,20 @@ be run individually, with the same initial configurations.
12321232
v1.16: Implemented phase 1 & 2 defined in the [implementation plan](#implementation-plan)
12331233
and launched in `Alpha`
12341234
1235-
v1.17: Implemented phase 3 defined [iplementation plan](#implementation-plan)
1235+
v1.17: Implemented phase 3 defined [implementation plan](#implementation-plan)
12361236
1237-
v1.18: Took user feedback on potentiall issues caused in feature enablement/disablement. Which lead us to redesign dual stack Services
1237+
v1.18: Took user feedback on potential issues caused in feature enablement/disablement, which led us to redesign dual-stack Services.
12381238
1239-
v1.19: Implemented redesigned duals stack Services see [PR 91824](https://github.com/kubernetes/kubernetes/pull/91824)
1239+
v1.19: Implemented redesigned dual-stack Services see [PR 91824](https://github.com/kubernetes/kubernetes/pull/91824)
12401240
12411241
v1.20: Relaunched to `Alpha`
12421242
1243+
v1.21: Moved from `Alpha` to `Beta`
1244+
1245+
v1.22: Gathering beta user feedback and making bugfixes as needed.
1246+
1247+
v1.23: Planning to move from `Beta` to `Stable`
1248+
12431249
## Alternatives
12441250
12451251
### Dual-stack at the Edge
@@ -1386,9 +1392,17 @@ This capability will move to stable when the following criteria have been met.
13861392
13871393
13881394
* **How can this feature be enabled / disabled in a live cluster?**
1389-
- [X] Feature gate (also fill in values in `kep.yaml`)
1395+
- While the feature is in beta:
1396+
[X] Feature gate (also fill in values in `kep.yaml`)
13901397
- Feature gate name: IPv6DualStack
1391-
- Components depending on the feature gate: kube-apiserver, kube-controller-manager, kube-proxy, and kubelet
1398+
- Components depending on the feature gate:
1399+
kube-apiserver, kube-controller-manager, kube-proxy, and kubelet
1400+
1401+
- When this feature moves to stable, the feature will always be enabled.
1402+
- While disabling the feature will not be possible after the move to stable,
1403+
using it is not required. Any cluster can be provisioned as single-stack by
1404+
setting `--cluster-cidr` to only one CIDR and ` --service-cluster-ip-range`
1405+
to only one address block.
13921406
13931407
* **Does enabling the feature change any default behavior?**
13941408
Pods and Services will remain single-stack until cli flags have been modified
@@ -1399,6 +1413,7 @@ This capability will move to stable when the following criteria have been met.
13991413
14001414
* **Can the feature be disabled once it has been enabled (i.e. can we roll back
14011415
the enablement)?**
1416+
14021417
Yes. If you decide to turn off dual-stack after turning on:
14031418
1. Ensure all services are converted to single-stack first (downgraded to
14041419
single-stack as described in this KEP)
@@ -1414,6 +1429,9 @@ This capability will move to stable when the following criteria have been met.
14141429
the feature is disabled, but no routing will happen and no
14151430
endpointSlices will be created while the feature is disabled.
14161431
1432+
- When the feature becomes stable, it will always be available. However, it
1433+
need not be used.
1434+
14171435
* **What happens if we reenable the feature if it was previously rolled back?**
14181436
14191437
If the system has no existing dual-stack services, then it will be treated
@@ -1430,10 +1448,10 @@ This capability will move to stable when the following criteria have been met.
14301448
iptables rules are fully propagated.
14311449
14321450
* **Are there any tests for feature enablement/disablement?**
1433-
The feature is being tested using integration tests with gate on/off. The
1434-
tests can be found here: https://github.com/kubernetes/kubernetes/tree/master/test/integration/dualstack
1451+
The feature is tested before going stable, using integration tests with gate
1452+
on/off. The tests can be found here: https://github.com/kubernetes/kubernetes/tree/master/test/integration/dualstack
14351453
1436-
The feature is being tested on a cloud provider and kind.
1454+
The feature is tested on a cloud provider and kind.
14371455
1. azure dual-stack e2e: https://testgrid.k8s.io/sig-network-dualstack-azure-e2e
14381456
2. kind dual-stack iptables: https://testgrid.k8s.io/sig-network-kind#sig-network-kind,%20dual,%20master
14391457
3. kind dual-stack ipvs: https://testgrid.k8s.io/sig-network-kind#sig-network-kind,%20ipvs,%20master
@@ -1460,7 +1478,7 @@ This capability will move to stable when the following criteria have been met.
14601478
following steps:
14611479
14621480
1. (preferred) Do not create dual-stack services until the rollout of the
1463-
dual-stack feature across the cluster is complete.
1481+
dual-stack feature (on supported versions) across the cluster is complete.
14641482
or
14651483
2. Cordon and drain the node(s) where the feature is not enabled
14661484

keps/sig-network/563-dual-stack/kep.yaml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ authors:
77
- "@lachie83"
88
- "@khenidak"
99
- "@feiskyer"
10+
- "@bridgetkromhout"
1011
owning-sig: sig-network
1112
participating-sigs:
1213
- sig-cluster-lifecycle
@@ -18,14 +19,14 @@ prr-approvers:
1819
- "@johnbelamaric"
1920
editor: TBD
2021
creation-date: "2018-05-21"
21-
last-updated: "2021-02-02"
22+
last-updated: "2021-05-03"
2223
status: implementable
2324
stage: beta
24-
latest-milestone: v1.21
25+
latest-milestone: v1.22
2526
milestone:
2627
alpha: "v1.20"
2728
beta: "v1.21"
28-
stable: "v1.22"
29+
stable: "v1.23"
2930
feature-gates:
3031
- name: IPv6DualStack
3132
components:

0 commit comments

Comments
 (0)