You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
future allow adding additional data without having to change code
570
575
other than that which uses the new information.
571
576
577
+
### Test Plan
578
+
579
+
572
580
#### Testing Strategy
573
581
574
582
The quota code is by an large not very amendable to unit tests. While
@@ -580,6 +588,40 @@ manager, particularly under stress). It also requires setup in the
580
588
form of a prepared filesystem. It would be better served by
581
589
appropriate end to end tests.
582
590
591
+
[x] I/we understand the owners of the involved components may require updates to
592
+
existing tests to make this code solid enough prior to committing the changes necessary
593
+
to implement this enhancement.
594
+
595
+
##### Prerequisite testing updates
596
+
597
+
<!--
598
+
Based on reviewers feedback describe what additional tests need to be added prior
599
+
implementing this enhancement to ensure the enhancements have also solid foundations.
600
+
-->
601
+
602
+
##### Unit tests
603
+
604
+
The main unit test is in package under `pkg/volume/util/fsquota/`.
605
+
606
+
- `pkg/volume/util/fsquota/`: `2022-06-20`- `73%`
607
+
- - project.go 75.7%
608
+
- - quota.go 100%
609
+
- - quota_linux.go 70.6%
610
+
611
+
See details in https://testgrid.k8s.io/sig-testing-canaries#ci-kubernetes-coverage-unit&include-filter-by-regex=fsquota.
612
+
613
+
##### Integration tests
614
+
615
+
N/A
616
+
617
+
##### e2e tests
618
+
619
+
e2e evolution (LocalStorageCapacityIsolationQuotaMonitoring [Slow] [Serial] [Disruptive] [Feature:LocalStorageCapacityIsolationQuota][NodeFeature:LSCIQuotaMonitoring]) can be found in [`test/e2e_node/quota_lsci_test.go`](https://github.com/kubernetes/kubernetes/blob/8cd689e40d253e520b1698d4bcf33992f0ae1d20/test/e2e_node/quota_lsci_test.go#L93-L103)
620
+
621
+
The e2e tests are slow and serial and we will not promote them to be conformance test then.
622
+
There is no failure history or flakes in https://storage.googleapis.com/k8s-triage/index.html?test=LocalStorageCapacityIsolationQuotaMonitoring
623
+
624
+
583
625
### Risks and Mitigations
584
626
585
627
* The SIG raised the possibility of a container being unable to exit
0 commit comments