Skip to content

Commit 4661e74

Browse files
committed
address / include some suggestions
1 parent 13a8be9 commit 4661e74

File tree

1 file changed

+3
-3
lines changed
  • keps/sig-testing/2420-reducing-kubernetes-build-maintenance

1 file changed

+3
-3
lines changed

keps/sig-testing/2420-reducing-kubernetes-build-maintenance/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,7 @@ and make progress.
199199
- Removing Bazel from sub-projects other than the core repo
200200
- Bazel comes with tradeoffs, each subproject can make its own decision in this regard. This KEP **only** covers the main Kubernetes repository, and nothing else.
201201
- Improving the previously existing make build
202-
- We should strongly consider improving the implementation and behavior of this build in the future, but this is largely orthogonal to whether we should consider maintaining two build systems.
202+
- We should strongly consider improving the implementation and behavior of this build in the future, but this is largely orthogonal to whether we should consider maintaining two build systems. An anticipated outcome of this KEP is increased bandwidth available to improve our single build system.
203203

204204
## Proposal
205205

@@ -251,7 +251,7 @@ proposal will be implemented, this is the place to discuss them.
251251
Non-blocking “make build” equivalents to kubernetes/kubernetes “bazel” CI jobs will be introduced (if they don’t already exist).
252252
When the new jobs provide equivalent signal, they will be moved to blocking, and the old jobs will be retired.
253253

254-
This is relevant for at least the following jobs:
254+
This is relevant for at least the following jobs release-blocking and merge-blocking:
255255
- `pull-kubernetes-bazel-test` (this can be converted to ~ `make test`)
256256
- `pull-kubernetes-bazel-build` (this largely overlaps with other presubmits, if not for testing ~`bazel build //...` and can likely be removed)
257257
- `periodic-bazel-build-<branch>` (this can likely already be removed in favor of `ci-kubernetes-build-<branch>`)
@@ -606,7 +606,7 @@ Major milestones might include:
606606
Why should this KEP _not_ be implemented?
607607
-->
608608

609-
- The make system works best from x86 (though it can cross compile all platforms), largely due to a [bug in the kube-cross image build] and some other small oversights / lack of attention, which we should fix anyhow.
609+
- The make system works best from x86 (though it can cross compile all platforms), largely due to a [bug in the kube-cross image build] and some other small oversights. Improving the existing make system is an explicit non-goal of this KEP, but we support addressing these oversights, and expect the outcome of this KEP will naturally increase available bandwidth to do so.
610610
- A few other issues related to CGO / $CC on non-amd64 build hosts have already received pull requests / fixes.
611611
- Remaining issues largely appear trivial, and should be fixed regardless, especially with the proliferation of non-amd64 developer hardware, where contributors will want to build releases matching the official release (with make).
612612

0 commit comments

Comments
 (0)