Skip to content

Commit 488232d

Browse files
committed
Update probe grace period KEP to beta
1 parent 29a891b commit 488232d

File tree

2 files changed

+9
-14
lines changed

2 files changed

+9
-14
lines changed

keps/sig-node/2238-liveness-probe-grace-period/README.md

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,9 @@ Items marked with (R) are required *prior to targeting to a milestone / release*
4343
- [X] (R) Graduation criteria is in place
4444
- [X] (R) Production readiness review completed
4545
- [X] (R) Production readiness review approved
46-
- [ ] "Implementation History" section is up-to-date for milestone
47-
- [ ] User-facing documentation has been created in [kubernetes/website], for publication to [kubernetes.io]
48-
- [ ] Supporting documentation—e.g., additional design documents, links to mailing list discussions/SIG meetings, relevant PRs/issues, release notes
46+
- [X] "Implementation History" section is up-to-date for milestone
47+
- [X] User-facing documentation has been created in [kubernetes/website], for publication to [kubernetes.io]
48+
- [X] Supporting documentation—e.g., additional design documents, links to mailing list discussions/SIG meetings, relevant PRs/issues, release notes
4949

5050
[kubernetes.io]: https://kubernetes.io/
5151
[kubernetes/enhancements]: https://git.k8s.io/enhancements
@@ -140,12 +140,6 @@ spec:
140140
terminationGracePeriodSeconds: 60
141141
```
142142
143-
### User Stories (Optional)
144-
145-
N/A - bugfix
146-
147-
### Notes/Constraints/Caveats (Optional)
148-
149143
### Risks and Mitigations
150144
151145
This should be a low-risk API change as it is backwards-compatible. If the
@@ -198,11 +192,13 @@ quickly.
198192
available behind a feature flag.
199193
- Appropriate tests are written.
200194

201-
_Below graduation criteria are tentative._
202-
203195
#### Beta
204196

205197
- Feature flag is defaulted on.
198+
- Remove feature gate from [kubelet](https://github.com/kubernetes/kubernetes/pull/99375#issuecomment-794680869).
199+
- Add validation to ensure `terminationGracePeriodSeconds` is non-negative.
200+
201+
_Below graduation criteria are tentative._
206202

207203
#### Graduation
208204

keps/sig-node/2238-liveness-probe-grace-period/kep.yaml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,12 @@ prr-approvers:
1818
- "@johnbelamaric"
1919

2020
# The target maturity stage in the current dev cycle for this KEP.
21-
stage: alpha
21+
stage: beta
2222

2323
# The most recent milestone for which work toward delivery of this KEP has been
2424
# done. This can be the current (upcoming) milestone, if it is being actively
2525
# worked on.
26-
latest-milestone: "v1.21"
26+
latest-milestone: "v1.22"
2727

2828
# The milestone at which this feature was, or is targeted to be, at each stage.
2929
milestone:
@@ -37,5 +37,4 @@ feature-gates:
3737
- name: ProbeTerminationGracePeriod
3838
components:
3939
- kube-apiserver
40-
- kubelet
4140
disable-supported: true

0 commit comments

Comments
 (0)