Skip to content

Commit 493309a

Browse files
authored
Merge pull request kubernetes#1818 from wojtek-t/prr_approvers_to_kep
Move PRR approvers to dedicated field in kep.yaml
2 parents 1b92f28 + 1a55e24 commit 493309a

File tree

5 files changed

+7
-5
lines changed
  • keps
    • sig-cluster-lifecycle/kubeadm/1739-customization-with-patches
    • sig-instrumentation/383-new-event-api-ga-graduation
    • sig-scheduling
      • 1451-multi-scheduling-profiles
      • 785-scheduler-component-config-api
    • sig-storage/1432-volume-health-monitor

5 files changed

+7
-5
lines changed

keps/sig-cluster-lifecycle/kubeadm/1739-customization-with-patches/kep.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ reviewers:
1111
- "@fabriziopandini"
1212
- "@rosti"
1313
approvers:
14-
- "@fabriziopandini" # PRR Approver
14+
- "@fabriziopandini"
1515
see-also:
1616
- "/keps/sig-cluster-lifecycle/kubeadm/20190722-Advanced-configurations-with-kubeadm-(Kustomize).md"
1717
replaces:

keps/sig-instrumentation/383-new-event-api-ga-graduation/kep.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,9 @@ reviewers:
1111
- "@yastij"
1212
- "@wojtekt"
1313
approvers:
14-
- "@wojtekt" # PRR Approver
1514
- "@brancz"
15+
prr-approvers:
16+
- "@wojtekt"
1617
creation-date: 2019-01-31
1718
last-updated: 2020-05-26
1819
status: implementable

keps/sig-scheduling/1451-multi-scheduling-profiles/kep.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,8 @@ reviewers:
1111
- "@liggitt"
1212
approvers:
1313
- "@Huang-Wei"
14-
- "@wojtek-t" # PRR Approver
14+
prr-approvers:
15+
- "@wojtek-t"
1516
see-also:
1617
- "/keps/sig-scheduling/20180409-scheduling-framework.md"
1718
- "/keps/sig-scheduling/20190226-default-even-pod-spreading.md"

keps/sig-scheduling/785-scheduler-component-config-api/kep.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,8 @@ reviewers:
1212
approvers:
1313
- "@ahg-g"
1414
- "@liggitt"
15-
- "@wojtek-t" # PRR Approver
15+
prr-approvers:
16+
- "@wojtek-t"
1617
see-also:
1718
- "/keps/sig-scheduling/1451-multi-scheduling-profiles"
1819
stage: beta

keps/sig-storage/1432-volume-health-monitor/kep.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ approvers:
1717
- "@saad-ali"
1818
- "@thockin"
1919
- "@liggitt"
20-
- "@oscar.doe" # PRR Approver
2120
see-also:
2221
replaces:
2322

0 commit comments

Comments
 (0)