Skip to content

Commit 4a1b8e0

Browse files
authored
Merge pull request kubernetes#3692 from aravindhp/KEP-2258-1.27
KEP 2258: Update milestones to 1.27
2 parents 306a505 + 59496a9 commit 4a1b8e0

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

keps/sig-windows/2258-node-service-log-viewer/README.md

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -195,10 +195,10 @@ configured. Here are some examples:
195195
The `/var/log/` endpoint is enabled using the `enableSystemLogHandler` kubelet
196196
configuration options. To gain access to this new feature this option needs to
197197
be enabled. In addition when introducing this feature it will be hidden behind a
198-
`NodeLogViewer` feature gate in the kubelet that needs to be explicitly enabled. So
198+
`NodeLogQuery` feature gate in the kubelet that needs to be explicitly enabled. So
199199
you need to enable both options to get access to this new feature and disabling
200200
`enableSystemLogHandler` will disable the new feature irrespective of the
201-
`NodeLogViewer` feature gate.
201+
`NodeLogQuery` feature gate.
202202

203203
A reference implementation of this feature is available
204204
[here](https://github.com/kubernetes/kubernetes/pull/96120).
@@ -240,7 +240,6 @@ Examples:
240240
241241
Options:
242242
-g, --grep='': Filter log entries by the provided regex pattern. Only applies to node journal logs.
243-
-o, --output='': Display journal logs in an alternate format (short, cat, json, short-unix). Only applies to node journal logs.
244243
--raw=false: Perform no transformation of the returned data.
245244
--role='': Set a label selector by node role.
246245
-l, --selector='': Selector (label query) to filter on.
@@ -302,13 +301,13 @@ e2e tests. For Windows a new set of tests will be added to the existing
302301

303302
### Graduation Criteria
304303

305-
The plan is to introduce the feature as alpha in the v1.26 time frame behind the
306-
`NodeLogViewer` kubelet feature gate and using the `kubectl alpha node-logs`
304+
The plan is to introduce the feature as alpha in the v1.27 time frame behind the
305+
`NodeLogQuery` kubelet feature gate and using the `kubectl alpha node-logs`
307306
sub-command.
308307

309308
#### Alpha -> Beta Graduation
310309

311-
The plan is to graduate the feature to beta in the v1.27 time frame. At that
310+
The plan is to graduate the feature to beta in the v1.28 time frame. At that
312311
point we would have collected feedback from cluster administrators and
313312
developers who have enabled the feature. Based on this feedback and issues
314313
opened we should consider adding a kubelet side throttle for the viewing the
@@ -320,7 +319,7 @@ The kubectl implementation will move from `kubectl alpha node-logs` to
320319
`kubectl node-logs`.
321320
#### Beta -> GA Graduation
322321

323-
The plan is to graduate the feature to GA in the v1.28 time frame at which point
322+
The plan is to graduate the feature to GA in the v1.29 time frame at which point
324323
any major issues should have been surfaced and addressed during the alpha and
325324
beta phases.
326325

@@ -338,13 +337,13 @@ viewer, the result should be "feature not supported".
338337

339338
* **How can this feature be enabled / disabled in a live cluster?**
340339
- [x] Feature gate
341-
- Feature gate name: NodeLogViewer
340+
- Feature gate name: NodeLogQuery
342341
- Components depending on the feature gate: kubelet
343342

344343
* **Does enabling the feature change any default behavior?** No
345344

346345
* **Can the feature be disabled once it has been enabled (i.e. can we roll back
347-
the enablement)?** Yes. It can be disabled by disabling the `NodeLogViewer` feature
346+
the enablement)?** Yes. It can be disabled by disabling the `NodeLogQuery` feature
348347
gate in the kubelet.
349348

350349
* **What happens if we reenable the feature if it was previously rolled back?**
@@ -408,6 +407,7 @@ resource usage (CPU, RAM, disk, IO, ...) in any components?**
408407

409408
- Created on Jan 14, 2021
410409
- Updated on May 5th, 2021
410+
- Updated on Dec 13th, 2022
411411

412412
## Drawbacks
413413

keps/sig-windows/2258-node-service-log-viewer/kep.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,16 +23,16 @@ stage: alpha
2323
# The most recent milestone for which work toward delivery of this KEP has been
2424
# done. This can be the current (upcoming) milestone, if it is being actively
2525
# worked on.
26-
latest-milestone: "v1.26"
26+
latest-milestone: "v1.27"
2727

2828
# The milestone at which this feature was, or is targeted to be, at each stage.
2929
milestone:
30-
alpha: "v1.26"
30+
alpha: "v1.27"
3131

3232
# The following PRR answers are required at alpha release
3333
# List the feature gate name and the components for which it must be enabled
3434
feature-gates:
35-
- name: NodeLogViewer
35+
- name: NodeLogQuery
3636
components:
3737
- kubelet
3838
disable-supported: true

0 commit comments

Comments
 (0)