@@ -195,10 +195,10 @@ configured. Here are some examples:
195
195
The ` /var/log/ ` endpoint is enabled using the ` enableSystemLogHandler ` kubelet
196
196
configuration options. To gain access to this new feature this option needs to
197
197
be enabled. In addition when introducing this feature it will be hidden behind a
198
- ` NodeLogViewer ` feature gate in the kubelet that needs to be explicitly enabled. So
198
+ ` NodeLogQuery ` feature gate in the kubelet that needs to be explicitly enabled. So
199
199
you need to enable both options to get access to this new feature and disabling
200
200
` enableSystemLogHandler ` will disable the new feature irrespective of the
201
- ` NodeLogViewer ` feature gate.
201
+ ` NodeLogQuery ` feature gate.
202
202
203
203
A reference implementation of this feature is available
204
204
[ here] ( https://github.com/kubernetes/kubernetes/pull/96120 ) .
@@ -240,7 +240,6 @@ Examples:
240
240
241
241
Options:
242
242
-g, --grep='': Filter log entries by the provided regex pattern. Only applies to node journal logs.
243
- -o, --output='': Display journal logs in an alternate format (short, cat, json, short-unix). Only applies to node journal logs.
244
243
--raw=false: Perform no transformation of the returned data.
245
244
--role='': Set a label selector by node role.
246
245
-l, --selector='': Selector (label query) to filter on.
@@ -302,13 +301,13 @@ e2e tests. For Windows a new set of tests will be added to the existing
302
301
303
302
### Graduation Criteria
304
303
305
- The plan is to introduce the feature as alpha in the v1.26 time frame behind the
306
- ` NodeLogViewer ` kubelet feature gate and using the ` kubectl alpha node-logs `
304
+ The plan is to introduce the feature as alpha in the v1.27 time frame behind the
305
+ ` NodeLogQuery ` kubelet feature gate and using the ` kubectl alpha node-logs `
307
306
sub-command.
308
307
309
308
#### Alpha -> Beta Graduation
310
309
311
- The plan is to graduate the feature to beta in the v1.27 time frame. At that
310
+ The plan is to graduate the feature to beta in the v1.28 time frame. At that
312
311
point we would have collected feedback from cluster administrators and
313
312
developers who have enabled the feature. Based on this feedback and issues
314
313
opened we should consider adding a kubelet side throttle for the viewing the
@@ -320,7 +319,7 @@ The kubectl implementation will move from `kubectl alpha node-logs` to
320
319
` kubectl node-logs ` .
321
320
#### Beta -> GA Graduation
322
321
323
- The plan is to graduate the feature to GA in the v1.28 time frame at which point
322
+ The plan is to graduate the feature to GA in the v1.29 time frame at which point
324
323
any major issues should have been surfaced and addressed during the alpha and
325
324
beta phases.
326
325
@@ -338,13 +337,13 @@ viewer, the result should be "feature not supported".
338
337
339
338
* ** How can this feature be enabled / disabled in a live cluster?**
340
339
- [x] Feature gate
341
- - Feature gate name: NodeLogViewer
340
+ - Feature gate name: NodeLogQuery
342
341
- Components depending on the feature gate: kubelet
343
342
344
343
* ** Does enabling the feature change any default behavior?** No
345
344
346
345
* ** Can the feature be disabled once it has been enabled (i.e. can we roll back
347
- the enablement)?** Yes. It can be disabled by disabling the ` NodeLogViewer ` feature
346
+ the enablement)?** Yes. It can be disabled by disabling the ` NodeLogQuery ` feature
348
347
gate in the kubelet.
349
348
350
349
* ** What happens if we reenable the feature if it was previously rolled back?**
@@ -408,6 +407,7 @@ resource usage (CPU, RAM, disk, IO, ...) in any components?**
408
407
409
408
- Created on Jan 14, 2021
410
409
- Updated on May 5th, 2021
410
+ - Updated on Dec 13th, 2022
411
411
412
412
## Drawbacks
413
413
0 commit comments