Skip to content

Commit 4b79572

Browse files
committed
node: podresources: add missing information
Add few missing details needed by the new KEP template. Signed-off-by: Francesco Romani <[email protected]>
1 parent 4fbd606 commit 4b79572

File tree

1 file changed

+9
-8
lines changed
  • keps/sig-node/606-compute-device-assignment

1 file changed

+9
-8
lines changed

keps/sig-node/606-compute-device-assignment/README.md

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ As such the external monitoring agents need to be able to determine the set of d
8484

8585
### Non-Goals
8686

87-
TBD
87+
* Enable cluster components to consume the API. The API is node-local only.
8888

8989
## Proposal
9090

@@ -175,19 +175,17 @@ The infrastructure required is expensive and it is not clear what additional tes
175175

176176
##### Prerequisite testing updates
177177

178-
TBD
179-
180178
##### Unit tests
181179

182-
TBD
180+
- `k8s.io/kubernetes/pkg/kubelet/apis/podresources`: `20230127` - `61.5%`
183181

184182
##### Integration tests
185183

186-
TBD
184+
covered by e2e tests
187185

188186
##### e2e tests
189187

190-
TBD
188+
- `k8s.io/kubernetes/test/e2e_node/podresources_test.go`: https://storage.googleapis.com/k8s-triage/index.html?test=POD%20Resources
191189

192190
### Graduation Criteria
193191

@@ -279,7 +277,7 @@ No.
279277
- Condition name:
280278
- Other field:
281279
- [X] Other (treat as last resort)
282-
- Details: TBD
280+
- Details: check the kubelet metrics `pod_resources_endpoint_*`
283281

284282
###### What are the reasonable SLOs (Service Level Objectives) for the enhancement?
285283

@@ -330,7 +328,10 @@ Feature only collects data when requests comes in, data is then garbage collecte
330328

331329
###### Can enabling / using this feature result in resource exhaustion of some node resources (PIDs, sockets, inodes, etc.)?
332330

333-
TBD
331+
No. Clients consume the API through the gRPC interface exposed from the unix domain socket. Only a single socket is created and managed by the kubelet,
332+
shared among all the clients (typically one). No resources are reserved when a client connects, and the API is stateless (no state preserved across
333+
calls, not concept of session). All the data needed to serve the calls is fetched by internal, already existing data structures internal to resource
334+
managers.
334335

335336
### Troubleshooting
336337

0 commit comments

Comments
 (0)