Skip to content

Commit 4c5fa94

Browse files
updated PRR
1 parent 7e55759 commit 4c5fa94

File tree

2 files changed

+17
-21
lines changed

2 files changed

+17
-21
lines changed

keps/sig-node/281-dynamic-kubelet-configuration/README.md

Lines changed: 15 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,10 @@ Items marked with (R) are required *prior to targeting to a milestone / release*
3232
- [X] (R) Test plan is in place, giving consideration to SIG Architecture and SIG Testing input
3333
- [X] (R) Graduation criteria is in place
3434
- [X] (R) Production readiness review completed
35-
- [ ] Production readiness review approved
36-
- [ ] "Implementation History" section is up-to-date for milestone
37-
- [ ] User-facing documentation has been created in [kubernetes/website], for publication to [kubernetes.io]
38-
- [ ] Supporting documentation—e.g., additional design documents, links to mailing list discussions/SIG meetings, relevant PRs/issues, release notes
35+
- [X] Production readiness review approved
36+
- [X] "Implementation History" section is up-to-date for milestone
37+
- [X] User-facing documentation has been created in [kubernetes/website], for publication to [kubernetes.io]
38+
- [X] Supporting documentation—e.g., additional design documents, links to mailing list discussions/SIG meetings, relevant PRs/issues, release notes
3939

4040
## Summary
4141

@@ -56,6 +56,8 @@ policy this feature is marked for deprecation as there were no interest expresse
5656
promote the feature to stable. Removal of Dynamic Kubelet Configuration logic will
5757
simplify code and improve code reliability.
5858

59+
The functionality was removed from kubelet in 1.24 and will be removed from API server in 1.26.
60+
5961
### Risks and Mitigations
6062

6163
The deprecation announcement may uncover wide feature usage.
@@ -119,31 +121,26 @@ find an owner committed to it.
119121

120122
* **What happens if we reenable the feature if it was previously rolled back?**
121123

122-
N/A
123-
124-
TODO: Section is to be updated once feature is scheduled for removal.
124+
N/A, feature is removed from kubelet.
125125

126126
* **Are there any tests for feature enablement/disablement?**
127127

128128
There will be no tests for the deprecation warnings.
129129

130-
TODO: Section is to be updated once feature is scheduled for removal.
131-
132130
### Rollout, Upgrade, and Rollback Planning
133131

134132
* **How can a rollout fail? Can it impact already running workloads?**
135133

136-
No, feature deprecation will not impact any workload.
137-
138-
TODO: Section is to be updated once feature is scheduled for removal.
134+
No, feature deprecation will not impact any workload. On removal of the
135+
feature, new kubelet versions will not apply any dynamic configuration.
139136

140137
* **What specific metrics should inform a rollback?**
141138

142-
TODO: Section is to be updated once feature is scheduled for removal.
139+
N/A, feature is removed
143140

144141
* **Were upgrade and rollback tested? Was the upgrade->downgrade->upgrade path tested?**
145142

146-
TODO: Section is to be updated once feature is scheduled for removal.
143+
N/A, feature is removed
147144

148145
### Monitoring Requirements
149146

@@ -158,15 +155,15 @@ effort needs to be scheduled.
158155

159156
* **What are the SLIs (Service Level Indicators) an operator can use to determine the health of the service?**
160157

161-
TODO: Section is to be updated once feature is scheduled for removal.
158+
N/A
162159

163160
* **What are the reasonable SLOs (Service Level Objectives) for the above SLIs?**
164161

165-
TODO: Section is to be updated once feature is scheduled for removal.
162+
N/A
166163

167164
* **Are there any missing metrics that would be useful to have to improve observability of this feature?**
168165

169-
TODO: Section is to be updated once feature is scheduled for removal.
166+
N/A
170167

171168
### Dependencies
172169

@@ -184,8 +181,6 @@ No
184181

185182
No
186183

187-
TODO: Section is to be updated once feature is scheduled for removal.
188-
189184
* **Will enabling / using this feature result in any new calls to the cloud provider?**
190185

191186
No
@@ -222,6 +217,7 @@ N/A
222217
- 1.9 Incremental improvements working towards 1.10 goals
223218
- 1.11 Beta release
224219
- 1.21 Feature is marked for deprecation
220+
- 1.24 Featuer is removed from kubelet. It will be removed from control plane in 1.26 to support version skew.
225221

226222
## Drawbacks
227223

keps/sig-node/281-dynamic-kubelet-configuration/kep.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,12 @@ see-also:
2121
replaces:
2222

2323
# The target maturity stage in the current dev cycle for this KEP.
24-
stage: beta (deprecated)
24+
stage: removed
2525

2626
# The most recent milestone for which work toward delivery of this KEP has been
2727
# done. This can be the current (upcoming) milestone, if it is being actively
2828
# worked on.
29-
latest-milestone: "v1.22"
29+
latest-milestone: "v1.24"
3030

3131
# The milestone at which this feature was, or is targeted to be, at each stage.
3232
milestone:

0 commit comments

Comments
 (0)