Skip to content

Commit 4c6a711

Browse files
committed
KEP-3325: SelfSubjectReview API Beta graduation
Signed-off-by: m.nabokikh <[email protected]>
1 parent f633d91 commit 4c6a711

File tree

3 files changed

+24
-16
lines changed

3 files changed

+24
-16
lines changed
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
11
kep-number: 3325
22
alpha:
33
approver: "@deads2k"
4+
beta:
5+
approver: "@deads2k"

keps/sig-auth/3325-self-subject-attributes-review-api/README.md

Lines changed: 21 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -243,16 +243,34 @@ We expect no non-infra related flakes in the last month as a GA graduation crite
243243

244244
#### Alpha
245245

246+
- `SelfSubjectReview` endpoint is introduced in `authentication.k8s.io/v1alpha1` API
246247
- Feature implemented behind a feature flag
247248
- Initial unit and integration tests completed and enabled
249+
- Corresponding kubectl command implemented: `kubectl alpha auth whoami`
248250

249251
#### Beta
250252

251253
- Gather feedback from users
254+
- `SelfSubjectReview` is promoted to `authentication.k8s.io/v1beta1` API
255+
- Promote feature gate to Beta and make it enabled by default
256+
- Unit tests coverage improved
257+
- `kubectl alpha auth whoami` command uses `authentication.k8s.io/v1beta1` API
258+
- Fix [documentation](https://kubernetes.io/docs/reference/access-authn-authz/authentication/#self-subject-review):
259+
- Change API version
260+
- Rewrite conditions to enable the feature
252261

253262
#### GA
254263

255-
- Corresponding kubectl command implemented
264+
- `SelfSubjectReview` is promoted to `authentication.k8s.io/v1` API
265+
- Promote feature gate to Stable
266+
- `kubectl alpha auth whoami` replaced with `kubectl auth whoami`
267+
- `kubectl auth whoami` command uses `authentication.k8s.io/v1` API
268+
- An article about motivation to use this feature is added to the Kubernetes blog
269+
- More integration and e2e tests cases
270+
- Fix [documentation](https://kubernetes.io/docs/reference/access-authn-authz/authentication/#self-subject-review):
271+
- Change API version
272+
- Rewrite conditions to enable the feature
273+
- Change kubectl command
256274

257275
NOTE: Should not be a part of [conformance tests](https://git.k8s.io/community/contributors/devel/sig-architecture/conformance-tests.md).
258276
The fact that a user possesses a token does not necessarily imply the power to know to whom that token belongs.
@@ -263,22 +281,9 @@ The fact that a user possesses a token does not necessarily imply the power to k
263281

264282
###### How can this feature be enabled / disabled in a live cluster?
265283

266-
<!--
267-
Pick one of these and delete the rest.
268-
-->
269-
270-
- Feature gate
284+
- [X] Feature gate (also fill in values in `kep.yaml`)
271285
- Feature gate name: `APISelfSubjectReview`
272-
- Components depending on the feature gate:
273-
- kube-apiserver
274-
275-
```go
276-
FeatureSpec{
277-
Default: false,
278-
LockToDefault: false,
279-
PreRelease: featuregate.Alpha,
280-
}
281-
```
286+
- Components depending on the feature gate: `kube-apiserver`
282287

283288
###### Does enabling the feature change any default behavior?
284289

keps/sig-auth/3325-self-subject-attributes-review-api/kep.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ reviewers:
1010
- "@enj"
1111
- "@deads2k"
1212
- "@mikedanese"
13+
- "@liggitt"
1314
approvers:
1415
- TBD
1516
creation-date: "2022-05-30"

0 commit comments

Comments
 (0)