Skip to content

Commit 4ded6c4

Browse files
authored
Merge pull request kubernetes#3644 from cici37/celUpdate
Add beta graduation criteria for CEL in Admission Control
2 parents e96e05d + 650fba3 commit 4ded6c4

File tree

1 file changed

+15
-0
lines changed
  • keps/sig-api-machinery/3488-cel-admission-control

1 file changed

+15
-0
lines changed

keps/sig-api-machinery/3488-cel-admission-control/README.md

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@
7373
- [e2e tests](#e2e-tests)
7474
- [Graduation Criteria](#graduation-criteria)
7575
- [Alpha](#alpha)
76+
- [Beta](#beta)
7677
- [Upgrade / Downgrade Strategy](#upgrade--downgrade-strategy)
7778
- [Version Skew Strategy](#version-skew-strategy)
7879
- [Production Readiness Review Questionnaire](#production-readiness-review-questionnaire)
@@ -1946,6 +1947,20 @@ in back-to-back releases.
19461947
- Feature implemented behind a feature flag
19471948
- Ensure proper tests are in place.
19481949

1950+
#### Beta
1951+
1952+
- benchmark and resolve optimization issues, including:
1953+
- add tests which registers a validation policy for everything and iterates through all groups/versions/resources/subresources
1954+
and ensures they get intercepted and work properly with a CEL validation policy([comment](https://github.com/kubernetes/kubernetes/pull/113314#discussion_r1013596456))
1955+
- set `paramKind` in a ValidatingAdmissionPolicy results in starting a new informer
1956+
that watches all instances of that object using a new unstructured informer which is inefficient([comment](https://github.com/kubernetes/kubernetes/pull/113314#discussion_r1013331221))
1957+
- switch to a lock-free implementation to address lock having to wait for all existing admission evaluations
1958+
to complete and blocking all new admission evaluations until this completes.([comment1](https://github.com/kubernetes/kubernetes/pull/113314#discussion_r1013318103),[comment2](https://github.com/kubernetes/kubernetes/pull/113314#discussion_r1013305167))
1959+
- Perform minimal possible number of conversions when evaluating multiple admission policies for a request resource.
1960+
If multiple admission policies require the same conversion, convert only once.
1961+
From @liggitt: "webhook code loops up one level, first accumulates all the validation webhooks we'll run, then converts to the versions needed by those webhooks then evaluates in parallel"
1962+
- authz check to the specific resource referenced in the policy's paramKind. ([comment](https://github.com/kubernetes/kubernetes/pull/113314#discussion_r1013135860))
1963+
19491964
### Upgrade / Downgrade Strategy
19501965

19511966
<!--

0 commit comments

Comments
 (0)