@@ -263,14 +263,13 @@ API validation, behavioral change of controllers with feature gate enabled and d
263
263
we will set new conditions on the mentioned workloads.
264
264
- Downgrades
265
265
When downgrading from a release with this feature, to a release without,
266
- we expect controllers not to remove stale conditions.
266
+ we expect controllers to honor the existing handling behaviour and not to remove the stale conditions.
267
267
268
268
### Version Skew Strategy
269
269
270
270
The update of extended conditions is always dependent on a ` ExtendedWorkloadConditions ` feature gate and not on the version as such.
271
271
If the feature gate is enabled, the workload controllers will update the extended conditions to reflect the current state.
272
- In case feature gate is disabled, the workload controllers will remove the stale conditions.
273
- In case the feature is missing in the workload controllers the conditions will not be removed and become stale.
272
+ In case feature gate is disabled or the feature is missing, the conditions will not be removed and become stale.
274
273
This feature has no node runtime implications.
275
274
276
275
## Production Readiness Review Questionnaire
@@ -292,9 +291,8 @@ No. The default behavior won't change. Only new conditions will be added with no
292
291
293
292
###### What happens if we reenable the feature if it was previously rolled back?
294
293
295
- When we disable a feature gate the extended conditions are not expected to be present in the statuses of workload objects,
296
- and thus should be removed by each responsible controller.
297
- Once we reenable the feature gate, the controllers should create and start updating the new workload conditions again.
294
+ When we disable a feature gate the extended conditions are expected to become stale and still be present in the statuses of workload objects.
295
+ Once we reenable the feature gate, the controllers should start updating the new workload conditions again.
298
296
299
297
###### Are there any tests for feature enablement/disablement?
300
298
0 commit comments