Skip to content

Commit 516d3c1

Browse files
committed
update KEP: consolidate workload controllers status
- do not remove the conditions on feature gate off to stay consistent
1 parent 23da23b commit 516d3c1

File tree

1 file changed

+4
-6
lines changed
  • keps/sig-apps/2804-consolidate-workload-controllers-status

1 file changed

+4
-6
lines changed

keps/sig-apps/2804-consolidate-workload-controllers-status/README.md

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -263,14 +263,13 @@ API validation, behavioral change of controllers with feature gate enabled and d
263263
we will set new conditions on the mentioned workloads.
264264
- Downgrades
265265
When downgrading from a release with this feature, to a release without,
266-
we expect controllers not to remove stale conditions.
266+
we expect controllers to honor the existing handling behaviour and not to remove the stale conditions.
267267

268268
### Version Skew Strategy
269269

270270
The update of extended conditions is always dependent on a `ExtendedWorkloadConditions` feature gate and not on the version as such.
271271
If the feature gate is enabled, the workload controllers will update the extended conditions to reflect the current state.
272-
In case feature gate is disabled, the workload controllers will remove the stale conditions.
273-
In case the feature is missing in the workload controllers the conditions will not be removed and become stale.
272+
In case feature gate is disabled or the feature is missing, the conditions will not be removed and become stale.
274273
This feature has no node runtime implications.
275274

276275
## Production Readiness Review Questionnaire
@@ -292,9 +291,8 @@ No. The default behavior won't change. Only new conditions will be added with no
292291

293292
###### What happens if we reenable the feature if it was previously rolled back?
294293

295-
When we disable a feature gate the extended conditions are not expected to be present in the statuses of workload objects,
296-
and thus should be removed by each responsible controller.
297-
Once we reenable the feature gate, the controllers should create and start updating the new workload conditions again.
294+
When we disable a feature gate the extended conditions are expected to become stale and still be present in the statuses of workload objects.
295+
Once we reenable the feature gate, the controllers should start updating the new workload conditions again.
298296

299297
###### Are there any tests for feature enablement/disablement?
300298

0 commit comments

Comments
 (0)