Skip to content

Commit 51bd118

Browse files
committed
KEP-1959: clarify field naming to loadBalancerClass
Signed-off-by: Andrew Sy Kim <[email protected]>
1 parent e9b84b1 commit 51bd118

File tree

2 files changed

+5
-2
lines changed
  • keps
    • prod-readiness/sig-cloud-provider
    • sig-cloud-provider/1959-service-lb-class-field

2 files changed

+5
-2
lines changed
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
kep-number: 1959
2+
alpha:
3+
approver: "@johnbelamaric"

keps/sig-cloud-provider/1959-service-lb-class-field/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -132,12 +132,12 @@ type ServiceSpec struct {
132132
// implementation is watching for Services with a matching class name. Any default load balancer
133133
// implementation (e.g. cloud providers) should ignore Services that set this field.
134134
// +optional
135-
LoadBalancerClassName string `json:"loadBalancerClass,omitempty"`
135+
LoadBalancerClass string `json:"loadBalancerClass,omitempty"`
136136
}
137137
```
138138

139139
* `loadBalancerClass` will be immutable only when the Service type is `LoadBalancer`, this way existing and future implementations
140-
do not have to worry about handling Services that change the class name. The class name is mutable and can be cleared when the
140+
do not have to worry about handling Services that change the class name. The class name is mutable and must be cleared when the
141141
type changes.
142142
* `loadBalancerClass` will be validated against label-style format.
143143
* the `loadBalancerClass` field will be feature gated. The field will be dropped during API strategy unless

0 commit comments

Comments
 (0)