Skip to content

Commit 54b409d

Browse files
committed
Update PRR KEP and KEP template for implementation
1 parent f70678f commit 54b409d

File tree

3 files changed

+17
-12
lines changed

3 files changed

+17
-12
lines changed

keps/NNNN-kep-template/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ Items marked with (R) are required *prior to targeting to a milestone / release*
130130
- [ ] (R) Test plan is in place, giving consideration to SIG Architecture and SIG Testing input
131131
- [ ] (R) Graduation criteria is in place
132132
- [ ] (R) Production readiness review completed
133-
- [ ] Production readiness review approved
133+
- [ ] (R) Production readiness review approved
134134
- [ ] "Implementation History" section is up-to-date for milestone
135135
- [ ] User-facing documentation has been created in [kubernetes/website], for publication to [kubernetes.io]
136136
- [ ] Supporting documentation—e.g., additional design documents, links to mailing list discussions/SIG meetings, relevant PRs/issues, release notes
@@ -360,7 +360,7 @@ Production readiness reviews are intended to ensure that features merging into
360360
Kubernetes are observable, scalable and supportable; can be safely operated in
361361
production environments, and can be disabled or rolled back in the event they
362362
cause increased failures in production. See more in the PRR KEP at
363-
https://git.k8s.io/enhancements/keps/sig-architecture/1194-prod-readiness/README.md.
363+
https://git.k8s.io/enhancements/keps/sig-architecture/1194-prod-readiness.
364364
365365
The production readiness review questionnaire must be completed and approved
366366
for the KEP to move to `implementable` status and be included in the release.

keps/sig-architecture/1194-prod-readiness/README.md

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -149,18 +149,21 @@ Status update on Phase 1:
149149
The questionnaire was put into place in Phase 1, so what remains for Phase 2 is
150150
to document the review process and implement the tooling supporting it.
151151

152-
The process will be enforced in the enhancements repository. When an enhancement
153-
is targeted at a release, a production readiness review will be necessary.
154-
Initially, the Enhancements Team will label the enhancement issue with a
155-
`prr-required` label; eventually tooling may do this automatically. The
156-
associated KEP must then be sure to add an approver from the
157-
`prod-readiness-review` team, which will be created in the `OWNERS_ALIASES` file
158-
of the enhancements repo. The enhancements verification CI must validate that a
159-
PRR approver is assigned to the KEP, and approves it prior to merging.
152+
The process will be enforced in the enhancements repository. A separate
153+
`prod-readiness` directory will be maintained, with an OWNERS file with
154+
PRR-specific reviewers and approvers. When targeting a release, the KEP author
155+
must:
156+
* Update the `kep.yaml`, setting the `stage`, `latest-milestone`, and the
157+
`milestone` struct (which captures per-stage release versions).
158+
* Create a `prod-readiness/<sig>/<KEP number>.yaml` file, with the PRR
159+
approver's GitHub handle for the specific stage.
160+
161+
The `kepval` utility / enhancements CI will be updated to enforce this.
160162

161163
## Implementation History
162164

163165
- 2019-07-31: Created
164166
- 2019-10-17: Review feedback, phase 1 implementable
165167
- 2019-11-12: Add establishment of subproject
166168
- 2020-04-21: Update for phase 2
169+
- 2020-12-15: Mark implemented, update phase 2 details

keps/sig-architecture/1194-prod-readiness/kep.yaml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,11 @@ reviewers:
1010
- "@vishh"
1111
- "@justaugustus"
1212
- "@alejandrox1"
13+
- "@wojtek-t"
14+
- "@deads2k"
1315
approvers:
1416
- "@derekwaynecarr"
1517
- "@dims"
1618
creation-date: 2019-07-31
17-
last-updated: 2020-04-21
18-
status: implementable
19+
last-updated: 2020-12-15
20+
status: implemented

0 commit comments

Comments
 (0)