Skip to content

Commit 5ad73f1

Browse files
authored
Merge pull request kubernetes#2976 from wzshiming/rename-api
KEP-2712: Rename internal api of PodPriorityBasedGracefulNodeShutdown
2 parents 9e5e92e + 4fc7ded commit 5ad73f1

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

keps/sig-node/2712-pod-priority-based-graceful-node-shutdown/README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -188,16 +188,16 @@ Same as the graceful shutdown KEP.
188188
## Design Details
189189

190190
The configuration will be controlled by a new Kubelet Config setting,
191-
`kubeletConfig.PodPriorityShutdownGracePeriods`:
191+
`kubeletConfig.ShutdownGracePeriodByPodPriority`:
192192

193193
```
194-
type PodPriorityShutdownGracePeriod struct {
194+
type ShutdownGracePeriodByPodPriority struct {
195195
Priority int32
196196
ShutdownGracePeriodSeconds int64
197197
}
198198
199199
type KubeletConfiguration struct {
200-
PodPriorityShutdownGracePeriods []PodPriorityShutdownGracePeriod
200+
ShutdownGracePeriodByPodPriority []ShutdownGracePeriodByPodPriority
201201
}
202202
```
203203

@@ -292,7 +292,7 @@ _This section must be completed when targeting alpha to a release._
292292

293293
* **How can this feature be enabled / disabled in a live cluster?**
294294
- [X] Feature gate (also fill in values in `kep.yaml`)
295-
- Feature gate name: `PodPriorityBasedGracefulNodeShutdown`
295+
- Feature gate name: `GracefulNodeShutdownBasedOnPodPriority`
296296
- Components depending on the feature gate:
297297
- `kubelet`
298298
- [ ] Other

keps/sig-node/2712-pod-priority-based-graceful-node-shutdown/kep.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ milestone:
2929
# The following PRR answers are required at alpha release
3030
# List the feature gate name and the components for which it must be enabled
3131
feature-gates:
32-
- name: PodPriorityBasedGracefulNodeShutdown
32+
- name: GracefulNodeShutdownBasedOnPodPriority
3333
components:
3434
- kubelet
3535
disable-supported: true

0 commit comments

Comments
 (0)