Merge pull request kubernetes#3129 from sanposhiho/lint-issue

k8s-ci-robot · web-flow · commit 5b8320131416 · 2022-03-21T09:27:20.000-07:00
Fix an issue from golangci-lint
diff --git a/pkg/repo/repo.go b/pkg/repo/repo.go
@@ -267,8 +267,8 @@ func (r *Repo) LoadLocalKEPs(sig string) ([]*api.Proposal, error) {
 
 	logrus.Debugf("loading the following local KEPs: %v", files)
 
-	var allKEPs []*api.Proposal
-	for _, kepYamlPath := range files {
+	allKEPs := make([]*api.Proposal, len(files))
+	for i, kepYamlPath := range files {
 		kep, err := r.loadKEPFromYaml(r.BasePath, kepYamlPath)
 		if err != nil {
 			return nil, errors.Wrapf(
@@ -278,7 +278,7 @@ func (r *Repo) LoadLocalKEPs(sig string) ([]*api.Proposal, error) {
 			)
 		}
 
-		allKEPs = append(allKEPs, kep)
+		allKEPs[i] = kep
 	}
 
 	logrus.Debugf("returning %d local KEPs", len(allKEPs))

Original file line number	Diff line number	Diff line change
`@@ -267,8 +267,8 @@ func (r Repo) LoadLocalKEPs(sig string) ([]api.Proposal, error) {`
`267`	`267`
`268`	`268`	`logrus.Debugf("loading the following local KEPs: %v", files)`
`269`	`269`
`270`		`- var allKEPs []*api.Proposal`
`271`		`- for _, kepYamlPath := range files {`
	`270`	`+ allKEPs := make([]*api.Proposal, len(files))`
	`271`	`+ for i, kepYamlPath := range files {`
`272`	`272`	`kep, err := r.loadKEPFromYaml(r.BasePath, kepYamlPath)`
`273`	`273`	`if err != nil {`
`274`	`274`	`return nil, errors.Wrapf(`
`@@ -278,7 +278,7 @@ func (r Repo) LoadLocalKEPs(sig string) ([]api.Proposal, error) {`
`278`	`278`	`)`
`279`	`279`	`}`
`280`	`280`
`281`		`- allKEPs = append(allKEPs, kep)`
	`281`	`+ allKEPs[i] = kep`
`282`	`282`	`}`
`283`	`283`
`284`	`284`	`logrus.Debugf("returning %d local KEPs", len(allKEPs))`