Merge pull request kubernetes#2240 from johnbelamaric/relax-prr-enforcement

k8s-ci-robot · web-flow · commit 5e532373fc26 · 2021-01-08T08:30:55.000-08:00
Disable enforcement of PRR requirements
diff --git a/cmd/kepval/main_test.go b/cmd/kepval/main_test.go
@@ -90,7 +90,10 @@ func TestValidation(t *testing.T) {
 				t.Errorf("%v has an error: %v", filename, kep.Error)
 			}
 
-			requiredPRRApproval := len(kep.Number) > 0 && kep.LatestMilestone >= "v1.21"
+			// temporarily disable PRR enforcement per https://github.com/kubernetes/enhancements/issues/2239
+			// so setting this to something always false
+			requiredPRRApproval := len(kep.Number) < 0
+			//requiredPRRApproval := len(kep.Number) > 0 && kep.LatestMilestone >= "v1.21"
 			if !requiredPRRApproval {
 				return
 			}

Original file line number	Diff line number	Diff line change
`@@ -90,7 +90,10 @@ func TestValidation(t *testing.T) {`
`90`	`90`	`t.Errorf("%v has an error: %v", filename, kep.Error)`
`91`	`91`	`}`
`92`	`92`
`93`		`- requiredPRRApproval := len(kep.Number) > 0 && kep.LatestMilestone >= "v1.21"`
	`93`	`+ // temporarily disable PRR enforcement per https://github.com/kubernetes/enhancements/issues/2239`
	`94`	`+ // so setting this to something always false`
	`95`	`+ requiredPRRApproval := len(kep.Number) < 0`
	`96`	`+ //requiredPRRApproval := len(kep.Number) > 0 && kep.LatestMilestone >= "v1.21"`
`94`	`97`	`if !requiredPRRApproval {`
`95`	`98`	`return`
`96`	`99`	`}`