|
15 | 15 | - [Notes/Constraints/Caveats (Optional)](#notesconstraintscaveats-optional)
|
16 | 16 | - [Risks and Mitigations](#risks-and-mitigations)
|
17 | 17 | - [Design Details](#design-details)
|
| 18 | + - [Integration tests](#integration-tests) |
| 19 | + - [e2e tests](#e2e-tests) |
18 | 20 | - [Graduation Criteria](#graduation-criteria)
|
19 | 21 | - [Alpha](#alpha)
|
20 | 22 | - [Deprecation](#deprecation)
|
@@ -210,6 +212,15 @@ See PR linked above for detailed design / behavior documentation.
|
210 | 212 |
|
211 | 213 | ### Test Plan
|
212 | 214 |
|
| 215 | +[x] I/we understand the owners of the involved components may require updates to |
| 216 | +existing tests to make this code solid enough prior to committing the changes |
| 217 | +necessary to implement this enhancement. |
| 218 | +
|
| 219 | +##### Prerequisite testing updates |
| 220 | +
|
| 221 | +
|
| 222 | +##### Unit tests |
| 223 | +
|
213 | 224 | For alpha, exhaustive Kubelet unit tests will be provided. Functions affected by the feature gate will be run with the feature gate on and with the feature gate off. Unit buckets will be provided for:
|
214 | 225 | - HashAuth - (new, small) returns a hash code for a CRI pull image auth [link](https://github.com/kubernetes/kubernetes/pull/94899/files#diff-ca08601dfd2fdf846f066d0338dc332beddd5602ab3a71b8fac95b419842da63R704-R751) ** per review comment will use SHA256 **
|
215 | 226 | - shouldPullImage - (modified, large sized change) determines if image should be pulled based on presence, and image pull policy, and now with the feature gate on if the image has been pulled/ensured by a secret. A unit test bucket did not exist for this function. The unit bucket will cover a matrix for:
|
@@ -240,7 +251,46 @@ For alpha, exhaustive Kubelet unit tests will be provided. Functions affected by
|
240 | 251 |
|
241 | 252 | PersistHashMeta() ** will be persisting SHA256 entries vs hash **
|
242 | 253 |
|
243 |
| -At beta we should revisit if integration buckets are warranted for e2e node and/or cri-tools/critest, and after gathering feedback. |
| 254 | +Additionally, for Alpha we will update this readme with an enumeration of the core packages being touched by the PR to implement this enhancement and provide the current unit coverage for those in the form of: |
| 255 | +- <package>: <date> - <current test coverage> |
| 256 | +The data will be read from: |
| 257 | +https://testgrid.k8s.io/sig-testing-canaries#ci-kubernetes-coverage-unit |
| 258 | +
|
| 259 | +##### Integration tests |
| 260 | +
|
| 261 | +At beta we will revisit if integration buckets are warranted for cri-tools/critest, and after gathering feedback. |
| 262 | +
|
| 263 | +<!-- |
| 264 | +Integration tests are contained in k8s.io/kubernetes/test/integration. |
| 265 | +Integration tests allow control of the configuration parameters used to start the binaries under test. |
| 266 | +This is different from e2e tests which do not allow configuration of parameters. |
| 267 | +Doing this allows testing non-default options and multiple different and potentially conflicting command line options. |
| 268 | +--> |
| 269 | +
|
| 270 | +<!-- |
| 271 | +This question should be filled when targeting a release. |
| 272 | +For Alpha, describe what tests will be added to ensure proper quality of the enhancement. |
| 273 | +
|
| 274 | +For Beta and GA, add links to added tests together with links to k8s-triage for those tests: |
| 275 | +https://storage.googleapis.com/k8s-triage/index.html |
| 276 | +--> |
| 277 | +
|
| 278 | +- <test>: <link to test coverage> (TBD) |
| 279 | +
|
| 280 | +##### e2e tests |
| 281 | +
|
| 282 | +<!-- |
| 283 | +This question should be filled when targeting a release. |
| 284 | +For Alpha, describe what tests will be added to ensure proper quality of the enhancement. |
| 285 | +
|
| 286 | +For Beta and GA, add links to added tests together with links to k8s-triage for those tests: |
| 287 | +https://storage.googleapis.com/k8s-triage/index.html |
| 288 | +
|
| 289 | +We expect no non-infra related flakes in the last month as a GA graduation criteria. |
| 290 | +--> |
| 291 | +At beta we will revisit if e2e buckets are warranted for e2e node, and after gathering feedback. |
| 292 | +
|
| 293 | +- <test>: <link to test coverage> (TBD) |
244 | 294 |
|
245 | 295 | ### Graduation Criteria
|
246 | 296 |
|
|
0 commit comments