1
- # KEP-2845: Deprecate klog specific flags in Kubernetes Compnents
1
+ # KEP-2845: Deprecate klog specific flags in Kubernetes Components
2
2
3
3
<!-- toc -->
4
4
- [ Release Signoff Checklist] ( #release-signoff-checklist )
@@ -158,7 +158,7 @@ Flags that should be deprecated:
158
158
159
159
Flag deprecation should comply with standard k8s policy and require 3 releases before removal.
160
160
161
- This leaves that two flags that should be implemented by all log formats
161
+ This leaves two flags that should be implemented by all log formats
162
162
163
163
* -v - control global log verbosity of Info logs
164
164
* --vmodule - control log verbosity of Info logs on per file level
@@ -172,6 +172,7 @@ default "text" format.
172
172
173
173
With removal of configuration alternatives we need to make sure that defaults
174
174
make sense. List of logging features implemented by klog and proposed actions:
175
+
175
176
* Routing logs based on type/verbosity - Supported by alternative logging formats.
176
177
* Writing logs to file - Feature removed.
177
178
* Log file rotation based on file size - Feature removed.
@@ -205,7 +206,7 @@ I0605 22:03:07.224378 3228948 logger.go:59] "Log using InfoS" key="value"
205
206
206
207
#### Writing logs to files
207
208
208
- We should use go-runner as a official fallback for users that want to retain
209
+ We should use go-runner as an official fallback for users that want to retain
209
210
writing logs to files. go-runner runs as parent process to components binary
210
211
reading it's stdout/stderr and is able to route them to files. go-runner is
211
212
already released as part of official K8s images it should be as simple as changing:
@@ -231,7 +232,7 @@ be treated as removal of any other flag.
231
232
232
233
Is it ok for K8s components to drop support writing to files?
233
234
Writing directly to files is an important feature still used by users, but this
234
- doesn't directly necessitates direct support in components. By providing a
235
+ doesn't directly necessitate direct support in components. By providing a
235
236
external solution like go-runner we can allow community to develop more advanced
236
237
features while maintaining high quality implementation within components.
237
238
Having more extendable solution developed externally should be more beneficial
@@ -350,7 +351,7 @@ k8s binaries, but this can be done one by one independently of other components.
350
351
- Will enabling / disabling the feature require downtime of the control
351
352
plane?
352
353
** Yes, for apiserver it will require a restart, which can be considered a
353
- control plane downtime in non highly available clusters**
354
+ control plane downtime in non- highly available clusters**
354
355
- Will enabling / disabling the feature require downtime or reprovisioning
355
356
of a node? (Do not assume ` Dynamic Kubelet Config ` feature is enabled).
356
357
** Yes, it will require restart of Kubelet**
0 commit comments