You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: keps/sig-instrumentation/1602-structured-logging/README.md
+5-5Lines changed: 5 additions & 5 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -381,8 +381,8 @@ Introduce structured logging and JSON format:
381
381
Bring feature quality up to and prevent regression during ongoing migration:
382
382
* Directories can be marked as migrated, preventing regression via verify script in `hack`.
383
383
*[Kubernetes Logging documentation](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-instrumentation/logging.md) is updated for structured logging.
384
-
*Json format should support same set of feature flags as text format, minus those we will decide to deprecte.
385
-
* Structured logging interface design is verify by migrating one whole component (Kubelet) to structured logging. All other component migrations will be best effort.
384
+
*JSON format should support same set of feature flags as text format, minus those we will decide to deprecate.
385
+
* Structured logging interface design is verified by migrating one whole component (Kubelet) to structured logging. All other component migrations will be best effort.
386
386
387
387
#### GA
388
388
@@ -417,7 +417,7 @@ For json format we used [zap](https://github.com/uber-go/zap).
417
417
418
418
Changes in format presented in this KEP will result in adding additional metadata to logs, potentially largely increasing log volume.
419
419
Unexpected log volume increase can lead to performance problems due exhausting disk IO or halting whole process when logs cannot be written on full disk.
420
-
To avoid breaking existing poduction clusters we would like to target of around 10% of log volume increase between kubernetes versions (proposed by @wojtekt).
420
+
To avoid breaking existing production clusters we would like to target of around 10% of log volume increase between kubernetes versions (proposed by @wojtekt).
421
421
422
422
During log volume analysis we would like to mainly focus on Kubernetes apiserver HTTP access logs. Those logs will have biggest impact
423
423
* They are responsible for 85% of log volume generated in cluster
@@ -443,7 +443,7 @@ Resulting log line is 248 characters long. Additional 42 characters has resulted
For migration to structured api we would like to propose to remove `statusStack` and `addedInfo` arguments. Our reasons:
446
+
For migration to structured API we would like to propose to remove `statusStack` and `addedInfo` arguments. Our reasons:
447
447
* Log format already neglects to put metadata for them, breaking the convention.
448
448
* We didn't find any case of those fields being non empty in [gce-master-scale-performance](https://k8s-testgrid.appspot.com/sig-scalability-gce#gce-master-scale-performance)
449
449
@@ -707,7 +707,7 @@ previous answers based on experience in the field._
0 commit comments