Skip to content

Commit 628974b

Browse files
committed
Update PRR comment wrt to enablement/disablement tests
1 parent a69f85d commit 628974b

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

keps/NNNN-kep-template/README.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -432,6 +432,12 @@ The e2e framework does not currently support enabling or disabling feature
432432
gates. However, unit tests in each component dealing with managing data, created
433433
with and without the feature, are necessary. At the very least, think about
434434
conversion tests if API types are being modified.
435+
436+
Additionally, for features that are introducing a new API field, unit tests that
437+
are exercising the `switch` of feature gate itself (what happens if I disable a
438+
feature gate after having objects written with the new field) are also critical.
439+
You can take a look at one potential example of such test in:
440+
https://github.com/kubernetes/kubernetes/pull/97058/files#diff-7826f7adbc1996a05ab52e3f5f02429e94b68ce6bce0dc534d1be636154fded3R246-R282
435441
-->
436442

437443
### Rollout, Upgrade and Rollback Planning

0 commit comments

Comments
 (0)