Skip to content

Commit 681e7a6

Browse files
Address reviewers comments
1 parent ef1d6bf commit 681e7a6

File tree

1 file changed

+6
-7
lines changed
  • keps/sig-scheduling/785-scheduler-component-config-api

1 file changed

+6
-7
lines changed

keps/sig-scheduling/785-scheduler-component-config-api/README.md

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,8 @@
4646
## Summary
4747

4848
The kube-scheduler configuration API `kubescheduler.config.k8s.io` was in alpha
49-
for several releases. We graduated it to beta in 1.19 as `v1beta1`. In 1.22,
50-
we introduced `v1beta2`. In 1.23, we plan to introduce `v1beta3`
49+
for several releases. We graduated it to beta in 1.19 as `v1beta1`. We introduced
50+
`v1beta2` and `v1beta3` in 1.22 and 1.23 respectively.
5151

5252
## Motivation
5353

@@ -70,7 +70,7 @@ usage.
7070

7171
- Introduce `kubescheduler.config.k8s.io/v1beta1` as a copy of
7272
`kubescheduler.config.k8s.io/v1alpha2` with minimal cleanup changes.
73-
- Iterate the API in `kubescheduler.config.k8s.io/v1beta3`, based on learnings.
73+
- Iterate the API in `kubescheduler.config.k8s.io/v1beta2`, `kubescheduler.config.k8s.io/v1beta3` based on learnings.
7474
- Use the newly created API objects to build the default configuration for kube-scheduler.
7575

7676
### Non-Goals
@@ -101,12 +101,11 @@ The third iteration, `kubescheduler.config.k8s.io/v1beta3`, includes the followi
101101
- Change the weight of plugins that can be influenced by end users through the Pod specs.
102102
- `InterPodAffinity` to 2
103103
- `NodeAffinity` to 2
104-
- `TaintToleration` to 3 as the usage of node tainting to group nodes in the cluster is a increasingly becoming a use-case
105-
for many user workloads
104+
- `TaintToleration` to 3 as leveraging node tainting to group nodes in the cluster is becoming a widely-adopted practice
106105

107106
The main reason is that some plugins have "default" behavior without needing user inputs, whereas the above plugins are
108107
about user preferences, so should have more influence while making scheduling decisions.
109-
More information on the discussion can be found [here](https://github.com/kubernetes/kubernetes/issues/88174)
108+
More information on the discussion can be found [here](https://github.com/kubernetes/kubernetes/issues/88174).
110109
### Risks and Mitigations
111110

112111
The major risk is around the removal of the `unreserve` extension point.
@@ -147,7 +146,7 @@ This will be documented in https://kubernetes.io/docs/reference/scheduling/profi
147146

148147
### Upgrade/Downgrade Strategy
149148

150-
Users are able to use the `v1beta1`, `v1beta2`, `v1beta3` APIs. Since they only affect
149+
Users are able to use the `v1beta1`, `v1beta2` or `v1beta3` API. Since they only affect
151150
the configuration of the scheduler, there is no impact to running workloads.
152151

153152
The default configurations preserve the behavior of the scheduler.

0 commit comments

Comments
 (0)