Skip to content

Commit 78ae07b

Browse files
committed
storage capacity: test examples + SLOs
1 parent 9a07ab8 commit 78ae07b

File tree

1 file changed

+7
-3
lines changed
  • keps/sig-storage/1472-storage-capacity-tracking

1 file changed

+7
-3
lines changed

keps/sig-storage/1472-storage-capacity-tracking/README.md

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -904,8 +904,10 @@ enhancement:
904904
* **Are there any tests for feature enablement/disablement?**
905905
The e2e framework does not currently support enabling and disabling feature
906906
gates. However, unit tests in each component dealing with managing data created
907-
with and without the feature are necessary and will be added before
908-
before the transition to beta.
907+
with and without the feature are necessary and were added before
908+
before the transition to beta, for example
909+
[in the apiserver](https://github.com/kubernetes/kubernetes/blob/v1.21.0/pkg/apis/storage/validation/validation_test.go#L2091-L2131)
910+
and the [volume binder](https://github.com/kubernetes/kubernetes/blob/v1.21.0/test/integration/volumescheduling/volume_binding_test.go#L706-L709).
909911

910912
### Rollout, Upgrade and Rollback Planning
911913

@@ -992,7 +994,9 @@ calls will be recorded with their non-OK status code as value.
992994
The goal is to achieve the same provisioning rates with the feature
993995
enabled as those that currently can be achieved without it.
994996

995-
This will need further discussion before going to GA.
997+
The SLOs depend on the CSI driver and how they are deployed. Therefore SLOs
998+
cannot be specified in more detail here. Cloud providers will have to determine
999+
what reasonable values are and document those.
9961000

9971001
* **Are there any missing metrics that would be useful to have to improve
9981002
observability if this feature?**

0 commit comments

Comments
 (0)