Merge pull request kubernetes#2357 from lingsamuel/fix-query-cmd

Fix query cmd `opts.Validate` and test func name

Author: k8s-ci-robot

cmd/kepctl/query.go

@@ -32,7 +32,7 @@ func buildQueryCommand(k *kepctl.Client) *cobra.Command {
 		Long:    "Query the local filesystem, and optionally GitHub PRs for KEPs",
 		Example: `  kepctl query --sig architecture --status provisional --include-prs`,
 		PreRunE: func(cmd *cobra.Command, args []string) error {
-			return opts.Validate(args)
+			return opts.Validate()
 		},
 		RunE: func(cmd *cobra.Command, args []string) error {
 			return k.Query(opts)

pkg/kepctl/query_test.go

@@ -23,48 +23,47 @@ import (
 	"github.com/stretchr/testify/require"
 )
 
-
-func TestValidate(t *testing.T) {
+func TestValidateQueryOpt(t *testing.T) {
 	testcases := []struct {
 		name      string
 		queryOpts QueryOpts
-		err 			error
+		err       error
 	}{
 		{
 			name: "Valid SIG",
 			queryOpts: QueryOpts{
-				CommonArgs: CommonArgs {
-					Name:     "1011-test",
+				CommonArgs: CommonArgs{
+					Name: "1011-test",
 				},
-				SIG:         []string{"sig-multicluster"},
-				IncludePRs:  true,
-				Output:      "json",
+				SIG:        []string{"sig-multicluster"},
+				IncludePRs: true,
+				Output:     "json",
 			},
-			err:  nil,
+			err: nil,
 		},
 		{
 			name: "Invalid SIG",
 			queryOpts: QueryOpts{
-				CommonArgs: CommonArgs {
-					Name:     "1011-test-xyz",
+				CommonArgs: CommonArgs{
+					Name: "1011-test-xyz",
 				},
-				SIG:         []string{"sig-xyz"},
-				IncludePRs:  true,
-				Output:      "json",
+				SIG:        []string{"sig-xyz"},
+				IncludePRs: true,
+				Output:     "json",
 			},
-			err:  fmt.Errorf("No SIG matches any of the passed regular expressions"),
+			err: fmt.Errorf("No SIG matches any of the passed regular expressions"),
 		},
 		{
 			name: "Unsupported Output format",
 			queryOpts: QueryOpts{
-				CommonArgs: CommonArgs {
-					Name:     "1011-test-testing",
+				CommonArgs: CommonArgs{
+					Name: "1011-test-testing",
 				},
-				SIG:         []string{"sig-testing"},
-				IncludePRs:  true,
-				Output:      "PDF",
+				SIG:        []string{"sig-testing"},
+				IncludePRs: true,
+				Output:     "PDF",
 			},
-			err:  fmt.Errorf("unsupported output format: PDF. Valid values: [table json yaml]"),
+			err: fmt.Errorf("unsupported output format: PDF. Valid values: [table json yaml]"),
 		},
 	}