Skip to content

Commit 809c51c

Browse files
authored
Merge pull request kubernetes#3165 from MadhavJivrajani/subresource-milestone
kep: kubectl subresource - update milestone
2 parents d22562d + 4f8c4a6 commit 809c51c

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

keps/sig-cli/2590-kubectl-subresource/README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ new flag `--subresource=[subresource-name]` which will allow fetching and updati
8989
`status` and `scale` subresources for all API resources.
9090

9191
Note that the API contract against the subresource is identical to a full resource. Therefore updating
92-
the status subresource to hold new value which could protentially be reconciled by a controller
92+
the status subresource to hold new value which could potentially be reconciled by a controller
9393
to a different value is *expected behavior*.
9494

9595
If `--subresource` flag is used for a resource that doesn't support the subresource,
@@ -119,11 +119,11 @@ nginx-deployment 3 3
119119
# for CRDS
120120
# a `get` on a status subresource will return identical information
121121
# to that of a full resource
122-
$ kubectl get crontab cron--subresource=status
122+
$ kubectl get crontab cron --subresource=status
123123
NAME SPEC REPLICAS AGE
124124
cron * * * * */5 3 4m52s
125125

126-
$ kubectl get vmset vmset-1 --subresource=scale
126+
$ kubectl get crontab cron --subresource=scale
127127
NAME DESIREDREPLICAS AVAILABLEREPLICAS
128128
cron 3 0
129129
```
@@ -147,7 +147,7 @@ $ kubectl patch deployment nginx-deployment --subresource='scale' --type='merge'
147147
scale.autoscaling/nginx-deployment patched
148148

149149
# spec.replicas is updated for the main resource
150-
$ k get deploy nginx-deployment
150+
$ kubectl get deploy nginx-deployment
151151
NAME READY UP-TO-DATE AVAILABLE AGE
152152
nginx-deployment 2/2 2 2 4m
153153

keps/sig-cli/2590-kubectl-subresource/kep.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,12 @@ prr-approvers:
1414
- "@johnbelamaric"
1515

1616
creation-date: 2021-04-06
17-
last-updated: 2021-09-08
17+
last-updated: 2022-01-20
1818

1919
status: implementable
2020
stage: alpha
2121

22-
latest-milestone: "v1.23"
22+
latest-milestone: "v1.24"
2323

2424
milestone:
25-
alpha: "v1.23"
25+
alpha: "v1.24"

0 commit comments

Comments
 (0)