lint: nolint refactor targets

Signed-off-by: Stephen Augustus <[email protected]>

Author: justaugustus

pkg/kepctl/create.go

@@ -121,6 +121,9 @@ func updateTemplate(t *api.Proposal, opts *CreateOpts) {
 	}
 
 	t.OwningSIG = opts.SIG
+
+	// TODO(lint): appendAssign: append result not assigned to the same slice (gocritic)
+	//nolint:gocritic
 	t.ParticipatingSIGs = append(opts.SIGS, opts.SIG)
 	t.Filename = opts.Name
 	t.LastUpdated = "v1.19"

pkg/kepctl/kepctl.go

@@ -178,6 +178,8 @@ func findLocalKEPMeta(repoPath, sig string) ([]string, error) {
 		"keps",
 		sig)
 
+	// TODO(lint): importShadow: shadow of imported from 'k8s.io/enhancements/pkg/kepval/keps' package 'keps' (gocritic)
+	//nolint:gocritic
 	keps := []string{}
 
 	// if the sig doesn't have a dir, it has no KEPs

pkg/kepval/keps/validations/yaml.go

@@ -33,6 +33,8 @@ var (
 	reMilestone   = regexp.MustCompile(`v1\\.[1-9][0-9]*`)
 )
 
+// TODO(lint): cyclomatic complexity 50 of func `ValidateStructure` is high (> 30) (gocyclo)
+//nolint:gocyclo
 func ValidateStructure(parsed map[interface{}]interface{}) error {
 	for _, key := range mandatoryKeys {
 		if _, found := parsed[key]; !found {
@@ -54,6 +56,8 @@ func ValidateStructure(parsed map[interface{}]interface{}) error {
 		// figure out the types
 		switch strings.ToLower(k) {
 		case "status":
+			// TODO(lint): singleCaseSwitch: should rewrite switch statement to if statement (gocritic)
+			//nolint:gocritic
 			switch v := value.(type) {
 			case []interface{}:
 				return util.NewValueMustBeString(k, v)
@@ -67,6 +71,8 @@ func ValidateStructure(parsed map[interface{}]interface{}) error {
 			}
 
 		case "stage":
+			// TODO(lint): singleCaseSwitch: should rewrite switch statement to if statement (gocritic)
+			//nolint:gocritic
 			switch v := value.(type) {
 			case []interface{}:
 				return util.NewValueMustBeString(k, v)
@@ -80,6 +86,8 @@ func ValidateStructure(parsed map[interface{}]interface{}) error {
 			}
 
 		case "owning-sig":
+			// TODO(lint): singleCaseSwitch: should rewrite switch statement to if statement (gocritic)
+			//nolint:gocritic
 			switch v := value.(type) {
 			case []interface{}:
 				return util.NewValueMustBeString(k, v)
@@ -102,6 +110,8 @@ func ValidateStructure(parsed map[interface{}]interface{}) error {
 			fallthrough
 
 		case "title", "creation-date", "last-updated":
+			// TODO(lint): singleCaseSwitch: should rewrite switch statement to if statement (gocritic)
+			//nolint:gocritic
 			switch v := value.(type) {
 			case []interface{}:
 				return util.NewValueMustBeString(k, v)
@@ -181,6 +191,8 @@ func ValidateStructure(parsed map[interface{}]interface{}) error {
 			}
 
 		case "latest-milestone":
+			// TODO(lint): singleCaseSwitch: should rewrite switch statement to if statement (gocritic)
+			//nolint:gocritic
 			switch v := value.(type) {
 			case []interface{}:
 				return util.NewValueMustBeString(k, v)
@@ -217,6 +229,8 @@ func validateMilestone(parsed map[interface{}]interface{}) error {
 			return util.NewKeyMustBeString(k)
 		}
 
+		// TODO(lint): singleCaseSwitch: should rewrite switch statement to if statement (gocritic)
+		//nolint:gocritic
 		switch strings.ToLower(k) {
 		case "alpha", "beta", "stable":
 			switch v := value.(type) {

pkg/kepval/keps/validations/yaml_test.go

@@ -24,7 +24,8 @@ import (
 	"gopkg.in/yaml.v2"
 )
 
-// TODO: Fix field keys and flow flags
+// TODO(lint): Fix field keys and flow flags
+//nolint:govet
 type proposal struct {
 	Title             string   `yaml:"title"`
 	Authors           []string `yaml:,flow`

pkg/kepval/prrs/validations/yaml.go

@@ -69,8 +69,12 @@ func validateMilestone(parsed map[interface{}]interface{}) error {
 		}
 
 		// figure out the types
+		// TODO(lint): singleCaseSwitch: should rewrite switch statement to if statement (gocritic)
+		//nolint:gocritic
 		switch strings.ToLower(k) {
 		case "approver":
+			// TODO(lint): singleCaseSwitch: should rewrite switch statement to if statement (gocritic)
+			//nolint:gocritic
 			switch v := value.(type) {
 			case []interface{}:
 				return util.NewValueMustBeString(k, v)