Skip to content

Commit 8f5ec59

Browse files
authored
Merge pull request kubernetes#1567 from enj/enj/i/sa_oidc_all_authenticated
oidc discovery kep: include system:serviceaccounts binding details
2 parents 0e409b4 + 8490539 commit 8f5ec59

File tree

1 file changed

+18
-4
lines changed

1 file changed

+18
-4
lines changed

keps/sig-auth/20190730-oidc-discovery.md

Lines changed: 18 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -245,10 +245,24 @@ field, as it is not necessary for token verification flows.
245245
The API server would treat these as `nonResourceURLs`, and restrict access
246246
appropriately. We will provide a default RBAC `ClusterRole` called
247247
`service-account-issuer-discovery` that provides `GET` access to these
248-
`nonResourceURLs`, but will *not* provide a default `ClusterRoleBinding`. This
249-
leaves the decision of who is allowed to access these endpoints up to cluster
250-
admins. A default binding requires further discussion, including ongoing efforts
251-
to harden the unauthenticated API surface area.
248+
`nonResourceURLs`. To make it easy for in-cluster workloads (via their
249+
service accounts) to consume this info, we will also provide a default
250+
`ClusterRoleBinding` that binds this role to all service accounts (via
251+
the `system:serviceaccounts` group).
252+
253+
Users with certain forms of write access (create pods, create secrets,
254+
create service accounts, etc) can gain access to a service account identity
255+
which would allow them to access this information. This includes the issuer
256+
URL, which is already present in the SA token JWT. Similarly, SAs can already
257+
gain this same info via introspection of their own token. Since this discovery
258+
endpoint points to what issued all service account tokens, it seems fitting for
259+
SAs to have this access.
260+
261+
Even though this information is not sensitive, we will *not* provide a
262+
default binding to all *authenticated* and/or *unauthenticated* users.
263+
Such a binding requires further discussion, including ongoing efforts to
264+
harden the unauthenticated API surface area. This leaves the decision of
265+
completely exposing these endpoints up to cluster admins.
252266

253267
### Risks and Mitigations
254268

0 commit comments

Comments
 (0)