Skip to content

Commit 938aa70

Browse files
committed
Catch up with initial implementation of borrowing in APF
Note the field renaming in `v1beta3`. Correct the setting of the smoothing decay coefficient.
1 parent c0738c6 commit 938aa70

File tree

1 file changed

+9
-8
lines changed
  • keps/sig-api-machinery/1040-priority-and-fairness

1 file changed

+9
-8
lines changed

keps/sig-api-machinery/1040-priority-and-fairness/README.md

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -705,12 +705,13 @@ type LimitedPriorityLevelConfiguration struct {
705705

706706
Prior to the introduction of borrowing, the `assuredConcurrencyShares`
707707
field had two meanings that amounted to the same thing: the total
708-
shares of the level, and the non-lendable shares of the level.
709-
While it is somewhat unnatural to keep the meaning of "total shares"
710-
for a field named "assured" shares, rolling out the new behavior into
708+
shares of the level, and the non-lendable shares of the level. While
709+
it is somewhat unnatural to keep the meaning of "total shares" for a
710+
field named "assured" shares, rolling out the new behavior into
711711
existing systems will be more continuous if we keep the meaning of
712-
"total shares" for the existing field. In the next version we should
713-
rename the `AssuredConcurrencyShares` to `NominalConcurrencyShares`.
712+
"total shares" for the existing field. In `v1beta3`
713+
`AssuredConcurrencyShares` has been renamed to
714+
`NominalConcurrencyShares`.
714715

715716
The limits on borrowing are two-sided: a given priority level has a
716717
limit on how much it may borrow and a limit on how much may be
@@ -787,9 +788,9 @@ immediately tracks EnvelopeSeatDemand when it exceeds
787788
SmoothSeatDemand. The rule for updating priority level `i`'s
788789
SmoothSeatDemand at the end of an adjustment period is
789790
`SmoothSeatDemand(i) := max( EnvelopeSeatDemand(i),
790-
A*SmoothSeatDemand(i) + (1-A)*EnvelopeSeatDemand(i) )`. The command
791-
line flag `--seat-demand-history-fraction` with a default value of 0.9
792-
configures A.
791+
A*SmoothSeatDemand(i) + (1-A)*EnvelopeSeatDemand(i) )`. The value of
792+
`A` is fixed at 0.977 in the code, which means that the half-life of
793+
the exponential decay is about 5 minutes.
793794

794795
Adjustment is also done on configuration change, when a priority level
795796
is introduced or removed or its NominalCL, LendableCL, or BorrowingCL

0 commit comments

Comments
 (0)