Merge pull request kubernetes#2528 from justaugustus/cleanup

Repo package cleanups/refactors (part two)

Author: k8s-ci-robot

.githooks/pre-commit

@@ -1,4 +1,4 @@
-# !/usr/bin/env bash
+#!/usr/bin/env bash
 
 # Copyright 2020 The Kubernetes Authors.
 #
@@ -20,4 +20,6 @@ set -o pipefail
 
 REPO_ROOT="$(git rev-parse --show-toplevel)"
 
-exec "${REPO_ROOT}/hack/verify.sh"
+exec "${REPO_ROOT}/hack/verify-kep-metadata.sh"
+exec "${REPO_ROOT}/hack/verify-toc.sh"
+exec "${REPO_ROOT}/hack/verify-spelling.sh"

api/proposal.go

@@ -86,23 +86,35 @@ func (p *Proposal) Validate() error {
 }
 
 func (p *Proposal) IsMissingMilestone() bool {
-	if p.LatestMilestone == "" {
-		return true
-	}
-
-	return false
+	return p.LatestMilestone == ""
 }
 
 func (p *Proposal) IsMissingStage() bool {
-	if p.Stage == "" {
-		return true
-	}
-
-	return false
+	return p.Stage == ""
 }
 
 type KEPHandler Parser
 
+func NewKEPHandler() (*KEPHandler, error) {
+	handler := &KEPHandler{}
+
+	groups, err := FetchGroups()
+	if err != nil {
+		return nil, errors.Wrap(err, "fetching groups")
+	}
+
+	handler.Groups = groups
+
+	approvers, err := FetchPRRApprovers()
+	if err != nil {
+		return nil, errors.Wrap(err, "fetching PRR approvers")
+	}
+
+	handler.PRRApprovers = approvers
+
+	return handler, nil
+}
+
 // TODO(api): Make this a generic parser for all `Document` types
 func (k *KEPHandler) Parse(in io.Reader) (*Proposal, error) {
 	scanner := bufio.NewScanner(in)

cmd/kepctl/cmd/create.go

@@ -16,8 +16,14 @@ limitations under the License.
 
 package main
 
-import "k8s.io/enhancements/cmd/kepctl/cmd"
+import (
+	"github.com/sirupsen/logrus"
+
+	"k8s.io/enhancements/pkg/kepctl/commands"
+)
 
 func main() {
-	cmd.Execute()
+	if err := commands.New().Execute(); err != nil {
+		logrus.Fatalf("error during command execution: %v", err)
+	}
 }