Skip to content

Commit 9aaec30

Browse files
Graduate Ready Pods in Job status to Beta
1 parent d452a4b commit 9aaec30

File tree

3 files changed

+20
-13
lines changed

3 files changed

+20
-13
lines changed
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
11
kep-number: 2879
22
alpha:
33
approver: "@wojtek-t"
4+
beta:
5+
approver: "@wojtek-t"

keps/sig-apps/2879-ready-pods-job-status/README.md

Lines changed: 16 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535

3636
Items marked with (R) are required *prior to targeting to a milestone / release*.
3737

38-
- [ ] (R) Enhancement issue in release milestone, which links to KEP dir in [kubernetes/enhancements] (not the initial KEP PR)
38+
- [x] (R) Enhancement issue in release milestone, which links to KEP dir in [kubernetes/enhancements] (not the initial KEP PR)
3939
- [x] (R) KEP approvers have approved the KEP status as `implementable`
4040
- [x] (R) Design details are appropriately documented
4141
- [ ] (R) Test plan is in place, giving consideration to SIG Architecture and SIG Testing input (including test refactors)
@@ -47,7 +47,7 @@ Items marked with (R) are required *prior to targeting to a milestone / release*
4747
- [x] (R) Production readiness review completed
4848
- [x] (R) Production readiness review approved
4949
- [ ] "Implementation History" section is up-to-date for milestone
50-
- [ ] User-facing documentation has been created in [kubernetes/website], for publication to [kubernetes.io]
50+
- [x] User-facing documentation has been created in [kubernetes/website], for publication to [kubernetes.io]
5151
- [ ] Supporting documentation—e.g., additional design documents, links to mailing list discussions/SIG meetings, relevant PRs/issues, release notes
5252

5353
[kubernetes.io]: https://kubernetes.io/
@@ -95,9 +95,9 @@ field based on the number of Pods that have the `Ready` condition.
9595
### Risks and Mitigations
9696

9797
- An increase in Job status updates. To mitigate this, the job controller holds
98-
the Pod updates that happen in X ms before syncing a Job. X will be determined
99-
from experiments on integration tests, but we expect it to be between 500ms
100-
and 1s.
98+
the Pod updates that happen in X ms before syncing a Job.
99+
From experiments using integration tests, X=500ms was found to be a reasonable
100+
value.
101101

102102
## Design Details
103103

@@ -107,7 +107,7 @@ field based on the number of Pods that have the `Ready` condition.
107107
type JobStatus struct {
108108
...
109109
Active int32
110-
Ready int32 // new field
110+
Ready *int32 // new field
111111
Succeeded int32
112112
Failed int32
113113
}
@@ -131,12 +131,17 @@ pods that have the `Ready` condition.
131131
#### Alpha
132132

133133
- Feature gate disabled by default.
134-
- Unit and integration tests passing.
134+
- Unit and [integration] tests passing.
135+
136+
[integration]: https://testgrid.k8s.io/conformance-all#Conformance%20-%20GCE%20-%20master&include-filter-by-regex=sig-apps&include-filter-by-regex=Job&exclude-filter-by-regex=CronJob
135137

136138
#### Beta
137139

138140
- Feature gate enabled by default.
139-
- Existing E2E and conformance tests passing.
141+
- Existing [E2E] and [conformance] tests passing.
142+
143+
[E2E]: https://testgrid.k8s.io/sig-apps#gce&include-filter-by-regex=apps%5C%5D%20Job
144+
[Conformance]: https://testgrid.k8s.io/conformance-all#Conformance%20-%20GCE%20-%20master&include-filter-by-regex=sig-apps&include-filter-by-regex=Job&exclude-filter-by-regex=CronJob
140145

141146
#### GA
142147

@@ -191,7 +196,7 @@ The Job controller will start populating the field again.
191196

192197
###### Are there any tests for feature enablement/disablement?
193198

194-
Yes, there will be tests at unit and integration level.
199+
Yes, there are tests at unit and [integration] level.
195200

196201
### Rollout, Upgrade and Rollback Planning
197202

@@ -301,7 +306,8 @@ No change from existing behavior of the Job controller.
301306

302307
## Implementation History
303308

304-
- 2021-08-19: Proposed KEP starting in beta status.
309+
- 2021-08-19: Proposed KEP starting in alpha status, including full PRR questionnaire.
310+
- 2022-01-05: Proposed graduation to beta.
305311

306312
## Drawbacks
307313

keps/sig-apps/2879-ready-pods-job-status/kep.yaml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,14 +15,13 @@ approvers:
1515
see-also:
1616
replaces:
1717

18-
stage: alpha
18+
stage: beta
1919

20-
latest-milestone: "v1.23"
20+
latest-milestone: "v1.24"
2121

2222
milestone:
2323
alpha: "v1.23"
2424
beta: "v1.24"
25-
stable: "v1.25"
2625

2726
feature-gates:
2827
- name: JobReadyPods

0 commit comments

Comments
 (0)