Skip to content

Commit 9b3612c

Browse files
authored
Merge pull request kubernetes#3696 from zshihang/master
KEP-2799: update for LegacyServiceAccountTokenTracking beta
2 parents 833b348 + 4c1dc51 commit 9b3612c

File tree

2 files changed

+10
-13
lines changed

2 files changed

+10
-13
lines changed

keps/sig-auth/2799-reduction-of-secret-based-service-account-token/README.md

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -142,9 +142,8 @@ indicates if tracking is enabled in the cluster. It is similar to the existing
142142

143143
- the controller creates/updates a configmap in `kube-system` namespace that
144144
stores the current date as `tracked-since`.
145-
- when a legacy token is used, issue a warning, annotate/update the
146-
`last-used` on the secret at date granularity, and record in a metric.
147-
optionally, add a label `in-use` for fast query.
145+
- when a legacy token is used, issue a warning, update the label `last-used`
146+
on the secret at date granularity, and record in a metric.
148147

149148
- When LegacyServiceAccountTokenTracking is disabled in any apiserver,
150149
- the controller ensures the configmap in `kube-system` namespace is deleted
@@ -235,10 +234,9 @@ legacy tokens for security practices.
235234

236235
#### Alpha -> Beta Graduation
237236

238-
- [ ] In use by multiple distributions
239-
- [ ] Approved by PRR and scalability
240-
- [ ] Any known bugs fixed
241-
- [ ] Tests passing
237+
- [x] Approved by PRR and scalability
238+
- [x] Any known bugs fixed
239+
- [x] Tests passing
242240

243241
#### LegacyServiceAccountTokenCleanUp
244242

@@ -255,7 +253,6 @@ legacy tokens for security practices.
255253

256254
#### Alpha -> Beta Graduation
257255

258-
- [ ] In use by multiple distributions
259256
- [ ] Approved by PRR and scalability
260257
- [ ] Any known bugs fixed
261258
- [ ] Tests passing
@@ -286,7 +283,7 @@ The only touches control plane, so version skew strategy is not applicable.
286283
###### Does enabling the feature change any default behavior?
287284

288285
- LegacyServiceAccountTokenNoAutoGeneration: no legacy tokens are auto-generated.
289-
- LegacyServiceAccountTokenTracking: legacy tokens would have new annotation and a configmap would be created in kube-system.
286+
- LegacyServiceAccountTokenTracking: legacy tokens would have new label and a configmap would be created in kube-system.
290287
- LegacyServiceAccountTokenCleanUp: unused auto-generated legacy tokens will be removed.
291288

292289
###### Can the feature be disabled once it has been enabled (i.e. can we roll back the enablement)?
@@ -299,7 +296,7 @@ yes for all feature gates.
299296
before the reenablement, Token Controller would create tokens for
300297
serviceaccounts while the feature was off.
301298
- LegacyServiceAccountTokenTracking: during this sequence of operations,
302-
only the annotation `last-used` is persisted, but there is no impact on the
299+
only the label `last-used` is persisted, but there is no impact on the
303300
functionality of this feature.
304301
- LegacyServiceAccountTokenCleanUp: the same as enable the feature.
305302

keps/sig-auth/2799-reduction-of-secret-based-service-account-token/kep.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,10 @@ reviewers:
1313
approvers:
1414
- "@liggitt"
1515
stage: beta
16-
latest-milestone: "v1.26"
16+
latest-milestone: "v1.27"
1717
milestone:
18-
alpha: "v1.24"
19-
beta: "v1.25"
18+
beta: "v1.24"
19+
stable: "v1.26"
2020
feature-gates:
2121
- name: LegacyServiceAccountTokenNoAutoGeneration
2222
components:

0 commit comments

Comments
 (0)