@@ -260,7 +260,7 @@ Consider including folks who also work outside the SIG or subproject.
260
260
-->
261
261
- Checking nodeAffinity and nodeTaints the same time may lead to performance
262
262
problem, we need to verify this by adding performance tests. If performance problem
263
- does exists, we'd like to add a node selector parser and cache the parsed object
263
+ does exists, we'd like to add a toleration parser and cache the parsed object
264
264
during PreFilter.
265
265
266
266
## Design Details
@@ -301,9 +301,9 @@ type PolicyName string
301
301
302
302
const (
303
303
// Ignore means ignore this policy in calculating.
304
- Ignore PolicyName = " ignore "
304
+ Ignore PolicyName = " Ignore "
305
305
// Respect means use this policy in calculating.
306
- Respect PolicyName = " respect "
306
+ Respect PolicyName = " Respect "
307
307
)
308
308
```
309
309
@@ -531,7 +531,7 @@ feature flags will be enabled on some API servers and not others during the
531
531
rollout. Similarly, consider large clusters and how enablement/disablement
532
532
will rollout across nodes.
533
533
-->
534
- A malformed configuration like non-exist policy will cause the scheduler failing to start. Running workloads are not affected.
534
+ N/A
535
535
536
536
###### What specific metrics should inform a rollback?
537
537
@@ -815,8 +815,11 @@ What other approaches did you consider, and why did you rule them out? These do
815
815
not need to be as detailed as the proposal, but should include enough
816
816
information to express the idea and why it was not acceptable.
817
817
-->
818
- - Changing the current behavior without introducing control.
819
- - Checking specific taints.
818
+ - The community has discussed about changing the current behavior implicitly,
819
+ but considering this will introduce a break user-facing change, for backwards
820
+ compatibility, we decided to add a feature as switch for end-users.
821
+ - We have also discussed about whether to support specific taints, but considering
822
+ there's no strong demands from end-users, we will delay this until needed.
820
823
821
824
## Infrastructure Needed (Optional)
822
825
0 commit comments