Skip to content

Commit a4f2182

Browse files
committed
update kep-1790 for milestone 1.28
1 parent ade6b45 commit a4f2182

File tree

2 files changed

+9
-10
lines changed

2 files changed

+9
-10
lines changed

keps/sig-storage/1790-recover-resize-failure/README.md

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
- [Goals](#goals)
1010
- [Non-Goals](#non-goals)
1111
- [Proposal](#proposal)
12-
- [Making resizeStatus more general in v1.27](#making-resizestatus-more-general-in-v127)
12+
- [Making resizeStatus more general in v1.28](#making-resizestatus-more-general-in-v128)
1313
- [Implementation](#implementation)
1414
- [User flow stories](#user-flow-stories)
1515
- [Case 0 (default PVC creation):](#case-0-default-pvc-creation)
@@ -108,7 +108,7 @@ As part of this proposal, we are mainly proposing three changes:
108108
- NodeExpansionFailed // state set when expansion has failed in kubelet with a terminal error. Transient errors don't set NodeExpansionFailed.
109109
3. Update quota code to use `max(pvc.Spec.Resources, pvc.Status.AllocatedResources)` when evaluating usage for PVC.
110110

111-
### Making resizeStatus more general in v1.27
111+
### Making resizeStatus more general in v1.28
112112

113113
After some discussion with sig-storage folks and to accommodate changes coming from https://github.com/kubernetes/enhancements/issues/3751 we are proposing that we rename `pvc.Status.ResizeStatus` to `pvc.Status.AllocatedResourceStatus` and make it a map.
114114

@@ -268,9 +268,8 @@ The complete expansion and recovery flow of both control-plane and kubelet is do
268268

269269
## Graduation Criteria
270270

271-
* *Alpha* in 1.23 behind `RecoverExpansionFailure` feature gate with set to a default of `false`.
272-
* *Beta* in 1.24: Since this feature is part of general `ExpandPersistentVolumes` feature which is in beta, we are going to move this to beta with enhanced e2e and more stability improvements.
273-
* *GA* in 1.26 along with `ExpandPersistentvolumes` feature. The list of issues for volume expansion going GA can be found at - https://github.com/orgs/kubernetes-csi/projects/12.
271+
* *Alpha* in 1.23 behind `RecoverVolumeExpansionFailure` feature gate with set to a default of `false`.
272+
* *Beta* in 1.29: We are going to move this to beta with enhanced e2e and more stability improvements.
274273

275274
### Test Plan
276275

@@ -288,7 +287,7 @@ The complete expansion and recovery flow of both control-plane and kubelet is do
288287

289288
* **How can this feature be enabled / disabled in a live cluster?**
290289
- [x] Feature gate (also fill in values in `kep.yaml`)
291-
- Feature gate name: `RecoverExpansionFailure`
290+
- Feature gate name: `RecoverVolumeExpansionFailure`
292291
- Components depending on the feature gate: kube-apiserver, kube-controller-manager, csi-external-resizer, kubelet
293292
- [ ] Other
294293
- Describe the mechanism:
@@ -390,7 +389,7 @@ _This section must be completed when targeting beta graduation to a release._
390389

391390
* **Does this feature depend on any specific services running in the cluster?**
392391
For CSI volumes this feature requires users to run with latest version of `external-resizer`
393-
sidecar which also should have `RecoverExpansionFailure` feature enabled.
392+
sidecar which also should have `RecoverVolumeExpansionFailure` feature enabled.
394393

395394
### Scalability
396395

keps/sig-storage/1790-recover-resize-failure/kep.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,21 +15,21 @@ approvers:
1515
- "@xing-yang"
1616
editor: TBD
1717
creation-date: 2020-01-27
18-
last-updated: 2022-01-26
18+
last-updated: 2023-06-13
1919
status: implementable
2020
see-also:
2121
replaces:
2222
superseded-by:
2323

24-
latest-milestone: "v1.27"
24+
latest-milestone: "v1.28"
2525
stage: "alpha"
2626

2727
milestone:
2828
alpha: "v1.23"
2929

3030

3131
feature-gates:
32-
- name: RecoverExpansionFailure
32+
- name: RecoverVolumeExpansionFailure
3333
components:
3434
- kube-apiserver
3535
- kube-controller-manager

0 commit comments

Comments
 (0)